util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anushree Mathur <anushree.mathur@linux.vnet.ibm.com>
To: util-linux@vger.kernel.org
Cc: Anjali K <anjalik@linux.ibm.com>,
	Anushree Mathur <anushree.mathur@linux.ibm.com>
Subject: Re: [PATCH] lscpu: fix incorrect number of sockets during hotplug
Date: Sun, 20 Oct 2024 16:00:03 +0530	[thread overview]
Message-ID: <5d52951c-82e6-435b-bb9b-1870b2a3d1ca@linux.vnet.ibm.com> (raw)
In-Reply-To: <20241018104335.3481856-1-anjalik@linux.ibm.com>

Hi,
I have verified the patch and it works fine!Here is my analysis:

LSCPU O/P on my system without enabling and disabling cpus

Architecture:             ppc64le
   Byte Order:             Little Endian
CPU(s):                   384
   On-line CPU(s) list:    0-383
Model name:               POWER10 (raw), altivec supported
   Model:                  2.0 (pvr 0080 0200)
   Thread(s) per core:     8
   Core(s) per socket:     12
   Socket(s):              4
   Physical sockets:       2
   Physical chips:         2
   Physical cores/chip:    12



Before applying the patch
While repeatedly onlining/offlining cpus on my system , saw that socket 
number is higher. It doesn't happen if i do online/offline of cpu single 
time.

Architecture:             ppc64le
   Byte Order:             Little Endian
CPU(s):                   384
   On-line CPU(s) list:    0-3,5-7,9,11-15,17-383
   Off-line CPU(s) list:   4,8,10,16
Model name:               POWER10 (raw), altivec supported
   Model:                  2.0 (pvr 0080 0200)
   Thread(s) per core:     8
   Core(s) per socket:     9
   Socket(s):              5
   Physical sockets:       2
   Physical chips:         2
   Physical cores/chip:    12



After applying the patch :
Tried the same scenario again to online and offline the cpus in a loop 
continuously and it didn't show any wrong topology:

Architecture:             ppc64le
   Byte Order:             Little Endian
CPU(s):                   384
   On-line CPU(s) list:    0-3,5-7,9,11-15,17-383
   Off-line CPU(s) list:   4,8,10,16
Model name:               POWER10 (raw), altivec supported
   Model:                  2.0 (pvr 0080 0200)
   Thread(s) per core:     8
   Core(s) per socket:     12
   Socket(s):              4
   Physical sockets:       2
   Physical chips:         2
   Physical cores/chip:    12

Tested-by: Anushree Mathur <anushree.mathur@linux.vnet.ibm.com>

Thanks,
Anushree Mathur

  reply	other threads:[~2024-10-20 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 10:43 [PATCH] lscpu: fix incorrect number of sockets during hotplug Anjali K
2024-10-20 10:30 ` Anushree Mathur [this message]
2024-10-30 10:55 ` Karel Zak
2024-11-04  6:37   ` Anjali K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d52951c-82e6-435b-bb9b-1870b2a3d1ca@linux.vnet.ibm.com \
    --to=anushree.mathur@linux.vnet.ibm.com \
    --cc=anjalik@linux.ibm.com \
    --cc=anushree.mathur@linux.ibm.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).