From: Mike Frysinger <vapier@gentoo.org>
To: Andreas Henriksson <andreas@fatal.se>
Cc: YunQiang Su <wzssyqa@gmail.com>, util-linux@vger.kernel.org
Subject: Re: [PATCH] libmount/buildsys: move SELINUX_LIBS to LDFLAGS
Date: Mon, 04 Aug 2014 03:40:56 -0400 [thread overview]
Message-ID: <7003188.HrNgjPCK9Z@vapier> (raw)
In-Reply-To: <20140803202309.GA26295@fatal.se>
[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]
On Sun 03 Aug 2014 22:23:09 Andreas Henriksson wrote:
> Hello Mike Frysinger!
>
> On Sun, Aug 03, 2014 at 09:34:25AM -0400, Mike Frysinger wrote:
> [...]
>
> > please post the full details here.
>
> I have no more details then those found in
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=721431
well, that thing has barely 6 lines (and even then requires some esoteric
knowledge from the reader), so you could have just pasted it here :p
------
In libmount/src/Makefile.am
libmount_la_LIBADD = $(ul_libblkid_la) $(SELINUX_LIBS)
libmount_la_DEPENDENCIES = $(libmount_la_LIBADD) libmount.sym libmount.h.in
While $(SELINUX_LIBS) is '-lselinux -lsepol'
They are not files or makefile tag, so cannot build-depends on.
------
the problem is that libmount_la_DEPENDENCIES shows up in the Makefile like:
libmount.la: ... $(libmount_la_DEPENDENCIES) ...
which means make evaluates it like so:
libmount.la: ... -lselinux -lsepol ...
which triggers the builtin library path searching of make itself:
https://www.gnu.org/software/make/manual/make.html#Libraries_002fSearch
which means it'll rewrite -lselinux into /usr/lib/libselinux.so (if it can
find it) which is bad for multilib and cross-compiling.
the easy answer is to not add LIBADD to DEPENDENCIES. which has been done
already -- see dbf7043ea1d090d283cfd36280bb14189d8e35b1.
> > linkage (like -lselinux) are not ldflags.
>
> Works for me, but likely I got LIBADD/LDFLAGS/LDADD wrong (again).
it often works in the common case, but the edges break down. we know putting
-lflags into LDFLAGS is such a scenario :).
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-04 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 20:11 [PATCH] libmount/buildsys: move SELINUX_LIBS to LDFLAGS Andreas Henriksson
2014-08-03 13:34 ` Mike Frysinger
2014-08-03 20:23 ` Andreas Henriksson
2014-08-04 7:40 ` Mike Frysinger [this message]
2014-08-04 9:49 ` Andreas Henriksson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7003188.HrNgjPCK9Z@vapier \
--to=vapier@gentoo.org \
--cc=andreas@fatal.se \
--cc=util-linux@vger.kernel.org \
--cc=wzssyqa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox