Re: [PATCH 3/3] tests: automatic whitespace trimming broke earlier commit

Sami Kerola
2014-02-17T09:01:52Z

On 17 February 2014 08:31, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday, January 15, 2014 20:15:53 Sami Kerola wrote:
>> Setting in .gitconfig to do 'git apply --whitespace=fix' automatically
>> turned automation against user.
>
> seems like git settings are still breaking these tests ? commit
> c367cda936f301b3d116a587356594b038de6d04 in the tree doesn't modify anything
> and three of the cal tests are failing because of trailing whitespace
> differences.

Hi Mike,

I found out the same, and mentioned about it in build target pull request.

http://www.spinics.net/lists/util-linux-ng/msg08858.html

This time I am pretty sure I sent the trailing spaces in patch, and
they seem to be present in archive.

http://www.spinics.net/lists/util-linux-ng/msg08752.html

Karel, is it possible something in your setup is removing trailing
spaces? Perhaps you could simply copy the cal test outputs to
expected directory, so that we can rid of this issue for good.

--
Sami Kerola