From: "Lennard Hofmann" <lennard.hofmann@web.de>
To: "Karel Zak" <kzak@redhat.com>
Cc: <util-linux@vger.kernel.org>
Subject: Re: [PATCH 1/4] column: Optionally keep empty lines in cols/rows mode
Date: Mon, 21 Sep 2020 18:00:18 +0200 [thread overview]
Message-ID: <C5T67UMNHUQJ.GSTUR3UATWLS@archbook> (raw)
In-Reply-To: <20200921130709.zvyf4siigxrdg77p@ws.net.home>
> It would be more robust to add also
>
> ctl->nents++;
>
> to this function.
Agreed. I thought that would require making this ugly change
-len = width(ctl->ents[ctl->nents]);
+len = width(ctl->ents[ctl->nents - 1]);
but `len = width(wcs);` is much better!
I will send patch v2 that includes patches 1 to 3 with your suggestions added.
Lennard
prev parent reply other threads:[~2020-09-21 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 12:55 [PATCH 1/4] column: Optionally keep empty lines in cols/rows mode Lennard Hofmann
2020-09-21 13:07 ` Karel Zak
2020-09-21 16:00 ` Lennard Hofmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5T67UMNHUQJ.GSTUR3UATWLS@archbook \
--to=lennard.hofmann@web.de \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox