From: Sami Kerola <kerolasa@iki.fi>
To: Karel Zak <kzak@redhat.com>
Cc: Benno Schulenberg <bensberg@justemail.net>,
Util-Linux <util-linux@vger.kernel.org>
Subject: Re: cytune: misnamed long options
Date: Tue, 6 May 2014 13:06:18 +0100 [thread overview]
Message-ID: <CAG27Bk111VDqEXCPeOxPyC7uyXFf+9EWTDi7Z1EaT45SiH63Aw@mail.gmail.com> (raw)
In-Reply-To: <20140506092650.GC5962@x2.net.home>
On 6 May 2014 10:26, Karel Zak <kzak@redhat.com> wrote:
> On Wed, Apr 30, 2014 at 12:25:49PM +0100, Sami Kerola wrote:
>> On 30 April 2014 09:52, Benno Schulenberg <bensberg@justemail.net> wrote:
>> > According to the code and the man page of cytune, the option -g
>> > shows the current values of the threshold and the flush timeout,
>> > and option -G shows the default values. But the corresponding
>> > long options of those two are: --get-threshold and --get-flush.
>> > Confusing. Shouldn't those be changed to --get-current and
>> > --get-defaults? (Or the first one maybe just --get?) However,
>> > the docs say not to change any options. What to do? Sami?
>>
>> Hi Benno,
>>
>> The recommendation never to change options tries to protect a Random J
>> Developer in breaking existing scripts. If options are deprecated at
>> least there should be a backwards compatibility with a deprecation
>> warning for some time (couple years).
>>
>> Looking the kernel interface
>>
>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/cyclades.c#n2639
>>
>> the 'threshold' keyword seems to be ok. Use of word 'flush' is a bit
>> odd, and 'timeout' would be closer match with what the kernel is
>> doing. Karel, are you OK with s/flush/timeout/ ABI change?
>
> NACK, it seems better to be backwardly compatible than perfect.
The NACK seems to indicate the change
https://github.com/kerolasa/lelux-utiliteetit/commit/2453ab9f64de49bb5a1b9a0bcd3653cd761a22b2
should not warnx(), nor be marked deprecated. Or to say other way, the
old long options should be silently accepted until end of universe.
Let me fix that (later the day when I'm not in office).
--
Sami Kerola
http://www.iki.fi/kerolasa/
prev parent reply other threads:[~2014-05-06 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 8:52 cytune: misnamed long options Benno Schulenberg
2014-04-30 11:25 ` Sami Kerola
2014-05-06 9:26 ` Karel Zak
2014-05-06 12:06 ` Sami Kerola [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG27Bk111VDqEXCPeOxPyC7uyXFf+9EWTDi7Z1EaT45SiH63Aw@mail.gmail.com \
--to=kerolasa@iki.fi \
--cc=bensberg@justemail.net \
--cc=kerolasa@gmail.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox