From: Samuel Thibault <samuel.thibault@gnu.org>
To: Karel Zak <kzak@redhat.com>
Cc: Zhaoming Luo <zhmingluo@163.com>,
util-linux@vger.kernel.org, bug-hurd@gnu.org
Subject: Re: [PATCH] hwclock: Support GNU Hurd
Date: Mon, 9 Dec 2024 11:36:22 +0100 [thread overview]
Message-ID: <Z1bIJjzgosmfF4xL@begin> (raw)
In-Reply-To: <kmz3eghhmo6rqlnenuwvcj3aa45elxajfdhwqiht52thxnb4qh@f2z34wslmajb>
Karel Zak, le lun. 09 déc. 2024 11:32:33 +0100, a ecrit:
> On Mon, Dec 09, 2024 at 10:58:15AM GMT, Zhaoming Luo wrote:
> > if (ctl->rtc_dev_name) {
> > rtc_dev_name = ctl->rtc_dev_name;
> > - rtc_dev_fd = open(rtc_dev_name, O_RDONLY);
> > + rtc_dev_fd = open(rtc_dev_name, O_RDWR);
>
> Why do you need O_RDWR on HURD?
For setting the time, it makes sense to request WR?
> Maybe it would be better to add an
> #ifdef, as it is unnecessary for Linux.
I have to say I'm surprised that Linux doesn't require it for setting
the time.
Samuel
next prev parent reply other threads:[~2024-12-09 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 2:58 [PATCH] hwclock: Support GNU Hurd Zhaoming Luo
2024-12-09 10:32 ` Karel Zak
2024-12-09 10:36 ` Samuel Thibault [this message]
2024-12-09 10:59 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1bIJjzgosmfF4xL@begin \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
--cc=zhmingluo@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox