From: Sami Kerola <kerolasa@iki.fi>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 9/9] agetty: fix invalid usage crash
Date: Sat, 5 Aug 2017 17:34:09 +0100 (BST) [thread overview]
Message-ID: <alpine.LNX.2.20.1708051733400.4995@imuri> (raw)
In-Reply-To: <20170801094212.72yitooyxbnq6o4j@ws.net.home>
On Tue, 1 Aug 2017, Karel Zak wrote:
> On Mon, Jul 31, 2017 at 08:55:08PM +0100, Sami Kerola wrote:
> > @@ -812,7 +813,8 @@ static void parse_args(int argc, char **argv, struct options *op)
> > parse_speeds(op, argv[optind++]);
> > if (argc < optind + 1) {
> > log_warn(_("not enough arguments"));
> > - warn(_("not enough arguments"));
> > + warnx(_("not enough arguments"));
> > + exit(EXIT_FAILURE);
>
> what about:
>
> errx(EXIT_FAILURE, _("not enough arguments"));
That is better. Updates in my 2017wk30 branch.
--
Sami Kerola
http://www.iki.fi/kerolasa/
next prev parent reply other threads:[~2017-08-05 16:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 19:54 [PATCH 0/9] pull: various removals and few fixes Sami Kerola
2017-07-31 19:55 ` [PATCH 1/9] chfn, chsh: merge auth.h, islocal.h and libuser.h to ch-common.h Sami Kerola
2017-08-01 9:27 ` Karel Zak
2017-08-05 16:33 ` Sami Kerola
2017-07-31 19:55 ` [PATCH 2/9] include: move pamfail.h to auth.c Sami Kerola
2017-07-31 19:55 ` [PATCH 3/9] vipw: use explicit_bzero() to clear buffer after copy Sami Kerola
2017-07-31 19:55 ` [PATCH 4/9] uuidparse: nil uuid have all bits set to zero Sami Kerola
2017-07-31 19:55 ` [PATCH 5/9] libuuid: use access(2) when checking /dev/random availability Sami Kerola
2017-07-31 19:55 ` [PATCH 6/9] bash-completion: look for look completions Sami Kerola
2017-07-31 19:55 ` [PATCH 7/9] agetty: remove dead DO_DEVFS_FIDDLING code segment Sami Kerola
2017-07-31 19:55 ` [PATCH 8/9] agetty: add --compile-time option Sami Kerola
2017-08-01 9:41 ` Karel Zak
2017-08-05 16:44 ` Sami Kerola
2017-07-31 19:55 ` [PATCH 9/9] agetty: fix invalid usage crash Sami Kerola
2017-08-01 9:42 ` Karel Zak
2017-08-05 16:34 ` Sami Kerola [this message]
2017-08-07 7:54 ` [PATCH 0/9] pull: various removals and few fixes Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.1708051733400.4995@imuri \
--to=kerolasa@iki.fi \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox