util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sami Kerola <kerolasa@iki.fi>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] rfkill: expand all acronyms in type string descriptions
Date: Mon, 16 Oct 2017 19:15:44 +0100 (BST)	[thread overview]
Message-ID: <alpine.LNX.2.20.1710161912540.918@imuri> (raw)
In-Reply-To: <20171016085834.u5ywmcgadkjtxbdu@ws.net.home>

On Mon, 16 Oct 2017, Karel Zak wrote:
> So, the default "list" output will be *again* backwardly incompatible :-)

Yep, that would not be good. I should have looked a little bit close what 
was done with these descriptiosn. Anyway, lets get the s/GPT/GPS/ fixed.

--->8----
>From 4a74c9b1675f4c4f2ff6ce69bdb5808da9c258af Mon Sep 17 00:00:00 2001
From: Sami Kerola <kerolasa@iki.fi>
Date: Sat, 14 Oct 2017 22:18:21 +0100
Subject: [PATCH] rfkill: fix description name typo

Commit 7d2a9960ad made gps to look like a GUID Partition Table.

Reviewed-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
 sys-utils/rfkill.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys-utils/rfkill.c b/sys-utils/rfkill.c
index 013806020..c31da7997 100644
--- a/sys-utils/rfkill.c
+++ b/sys-utils/rfkill.c
@@ -64,7 +64,7 @@ static const struct rfkill_type_str rfkill_type_strings[] = {
 	{ .type = RFKILL_TYPE_UWB,       .name = "ultrawideband" }, /* alias */
 	{ .type = RFKILL_TYPE_WIMAX,     .name = "wimax",        .desc = "WiMAX" },
 	{ .type = RFKILL_TYPE_WWAN,      .name = "wwan",         .desc = "Wireless WAN" },
-	{ .type = RFKILL_TYPE_GPS,       .name = "gps",          .desc = "GPT" },
+	{ .type = RFKILL_TYPE_GPS,       .name = "gps",          .desc = "GPS" },
 	{ .type = RFKILL_TYPE_FM,        .name = "fm",           .desc = "FM" },
 	{ .type = RFKILL_TYPE_NFC,       .name = "nfc",          .desc = "NFC" },
 	{ .type = NUM_RFKILL_TYPES,      .name = NULL            }
-- 
2.14.2


  reply	other threads:[~2017-10-16 18:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-14 21:35 [PATCH] rfkill: expand all acronyms in type string descriptions Sami Kerola
2017-10-16  8:58 ` Karel Zak
2017-10-16 18:15   ` Sami Kerola [this message]
2017-10-17  8:16     ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.20.1710161912540.918@imuri \
    --to=kerolasa@iki.fi \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).