From: Paul Benoit <paul@os.amperecomputing.com>
To: Jeremy Linton <jeremy.linton@arm.com>, Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 2/2] lscpu-arm: Remove the "Ampere-1a" part.
Date: Mon, 14 Jul 2025 18:22:28 -0400 [thread overview]
Message-ID: <eadbcad4-6392-4429-ab6c-8b820fcbd3dd@os.amperecomputing.com> (raw)
In-Reply-To: <fb54d607-dccc-419f-b92c-7bc8514213a6@arm.com>
On 7/14/2025 4:48 PM, Jeremy Linton wrote:
> On 7/14/25 7:16 AM, Karel Zak wrote:
>> On Fri, Jul 11, 2025 at 02:16:48PM -0700, Paul Benoit wrote:
>>> Remove the "Ampere-1a" part. On newer Ampere Computing systems, the
>>> system/model name will be obtained from /sys/bus/soc/devices/soc0/
>>> machine,
>>> that is populated with the ARM SMC CC SOC_ID Name.
>>
>> If I understand correctly, there are old systems without
>> /sys/.../soc0/machine, right? The change will remove Ampere-1a from
>> the lscpu output. This sounds backward incompatible.
>
> Thats a good point, but as I understand it, Ampere hasn't been happy
> with the string that is there.
>
Hi Jeremy and Karel,
While I haven't personally been part of those discussions, that's also
my understanding of the situation.
> If its OK to break whatever scripts/etc might depend on it at the
> moment, why not just update the string.
>
That's becoming even more tempting given the valid issues that you and
Karel have identified with my patch. Though, the nice thing about lscpu
picking up the Model name, from somewhere like
/sys/bus/soc/devices/soc0/, is that lscpu will be able to output the
model name of newly released processors without/before them needing to
be added to the lscpu part(s) table. That assumes a kernel where either
the ARM SMC CC SOC_ID (Name) handling code, or the support code for a
specific SOC, set the Model name from which /sys/bus/soc/devices/soc0/
gets set.
> Then invert the check so that the /sys/bus entry is preferred?
>
That's the way I had originally coded things, but I was concerned about
the change in behavior of having the /sys/bus/soc/devices/soc0/ value
override the established part(s) table names for non-Ampere processors.
next prev parent reply other threads:[~2025-07-14 22:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 21:16 [PATCH 1/2] lscpu-arm: Allow externally sourced model name Paul Benoit
2025-07-11 21:16 ` [PATCH 2/2] lscpu-arm: Remove the "Ampere-1a" part Paul Benoit
2025-07-14 12:16 ` Karel Zak
2025-07-14 20:48 ` Jeremy Linton
2025-07-14 22:22 ` Paul Benoit [this message]
2025-07-15 9:19 ` Karel Zak
2025-11-07 21:26 ` Paul Benoit
2025-11-07 20:48 ` Paul Benoit
2026-02-11 21:23 ` [PATCH v2 1/2] lscpu-arm: Include the ARM SMC CC SOC_ID name Paul Benoit
2026-02-11 21:23 ` [PATCH v2 2/2] lscpu-arm: Correct Ampere part name strings Paul Benoit
2025-07-11 22:22 ` [PATCH 1/2] lscpu-arm: Allow externally sourced model name Jeremy Linton
2025-11-07 21:45 ` Paul Benoit
2025-07-14 12:11 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eadbcad4-6392-4429-ab6c-8b820fcbd3dd@os.amperecomputing.com \
--to=paul@os.amperecomputing.com \
--cc=jeremy.linton@arm.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox