From: Joe Jin <joe.jin@oracle.com>
To: Karel Zak <kzak@redhat.com>
Cc: Zhenwei Pi <pizhenwei@bytedance.com>,
Sami Kerola <kerolasa@iki.fi>,
util-linux@vger.kernel.org
Subject: Re: [RFC PATCH 0/2]lsirq,irqtop: Add filter support
Date: Mon, 10 Mar 2025 08:27:12 -0700 [thread overview]
Message-ID: <f7c71470-1ecd-4022-a7b1-189ce7fa3fcb@oracle.com> (raw)
In-Reply-To: <qdiia2fmgfxwgr75qjdgxuiitaoo66tsthajqxs6mrtca6oqh4@irpn3e44w4sw>
On 3/10/25 05:14, Karel Zak wrote:
> On Thu, Mar 06, 2025 at 06:51:59PM GMT, Joe Jin wrote:
>> Sometimes people may only be interested in a specific IRQ, adding regular
>> expression support can help engineers find/monitor IRQs easily.
> Ah, the libsmartcols provides a filter. See, for example, misc-utils/lsblk.c and
> the "-Q" command line option, and also "man scols-filter".
>
> scols_new_filter()
> scols_line_apply_filter()
> scols_line_is_filled()
> ... etc.
>
> https://www.kernel.org/pub/linux/utils/util-linux/v2.41/libsmartcols-docs/libsmartcols-Filters-and-counters.html
>
> The filter allows the creation of complex queries, so if we integrate
> it into lsirq and irqtop, it will be possible to use things like:
>
> irqtop -Q 'NAME ~= "PCI\-.*" && TOTAL > 100'
This looks more powerful, thanks for your suggestions.
Best Regards,
Joe
>
>
> Karel
>
prev parent reply other threads:[~2025-03-10 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 2:51 [RFC PATCH 0/2]lsirq,irqtop: Add filter support Joe Jin
2025-03-07 2:52 ` [RFC PATCH 1/2] lsirq: add " Joe Jin
2025-03-07 2:52 ` [RFC PATCH 2/2] irqtop: " Joe Jin
2025-03-07 11:45 ` Benno Schulenberg
2025-03-07 15:30 ` Joe Jin
2025-03-09 11:39 ` Benno Schulenberg
2025-03-10 12:14 ` [RFC PATCH 0/2]lsirq,irqtop: Add " Karel Zak
2025-03-10 15:27 ` Joe Jin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7c71470-1ecd-4022-a7b1-189ce7fa3fcb@oracle.com \
--to=joe.jin@oracle.com \
--cc=kerolasa@iki.fi \
--cc=kzak@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).