From: Benno Schulenberg <bensberg@coevern.nl>
To: sina-abroshan <sina.abroshan@gmail.com>, util-linux@vger.kernel.org
Cc: kzak@redhat.com
Subject: Re: [PATCH] lsblk: improve error reporting for invalid device paths
Date: Sat, 14 Feb 2026 16:24:42 +0100 [thread overview]
Message-ID: <ff9b88bf-351b-47a8-95d3-dffa23f059ea@coevern.nl> (raw)
In-Reply-To: <20260212112423.2400888-1-sina.abroshan@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 553 bytes --]
Op 12-02-2026 om 12:24 schreef sina-abroshan:
> - struct stat st;
> + struct stat st;
>
> - DBG(DEV, ul_debug("%s: reading alone device", devname));
> + DBG(DEV, ul_debug("%s: reading alone device", devname));
Why these whitespace changes? There should be tabs there, not spaces.
> - if (stat(devname, &st) || !S_ISBLK(st.st_mode)) {
> + if (stat(devname, &st) != 0) {
> + warn(_("%s"), devname);
Gettextizing a message that contains nothing translatable is pointless.
In other words: drop the _() call.
Benno
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2026-02-14 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 11:24 [PATCH] lsblk: improve error reporting for invalid device paths sina-abroshan
2026-02-14 15:24 ` Benno Schulenberg [this message]
2026-02-15 8:34 ` sina-abroshan
2026-02-18 10:01 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff9b88bf-351b-47a8-95d3-dffa23f059ea@coevern.nl \
--to=bensberg@coevern.nl \
--cc=kzak@redhat.com \
--cc=sina.abroshan@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox