login/telnet problems

[Henrik Grindal Bakken <hgb@ifi.uio.no>]

Hi.  I'm working on a product which (sadly) requires telnet, and after
an upgrade from util-linux-2.20 to 2.22.2, telnet starts acting up by
dropping the first character (at least that's the easiest problem to
spot).

I looked around, and determined that the problem was related to
upgrading login(1).  Further, I bisected util-linux, and determined
that the problem was introduced by:

commit 2e7035646eb85851171cc2e989bfa858a4f00cd4
Author: Karel Zak <kzak@redhat.com>
Date:   Thu Jul 12 16:33:52 2012 +0200

    login: close tty before vhangup()
    
    Let's close all tty file descriptors before vhangup() call.
    
    References: https://lkml.org/lkml/2012/6/5/145
    Signed-off-by: Karel Zak <kzak@redhat.com>


I reverted that commit locally, and telnet started working nicely
again.  This is netkit-telnet-0.17, btw.

It's not a huge problem for me to keep a local revert of this commit,
but I thought perhaps you wanted to know it did actually break
something (although one can argue the very existence of telnet these
days is a bug...).


-- 
Henrik Grindal Bakken <hgb@ifi.uio.no>
PGP ID: 8D436E52
Fingerprint: 131D 9590 F0CF 47EF 7963  02AF 9236 D25A 8D43 6E52