From: David Howells <dhowells@redhat.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: dhowells@redhat.com, Eric Van Hensbergen <ericvh@kernel.org>,
v9fs@lists.linux.dev, linux_oss@crudebyte.com
Subject: Re: fs/9p: regression in 6.8-rc1
Date: Mon, 29 Jan 2024 09:20:08 +0000 [thread overview]
Message-ID: <1217440.1706520008@warthog.procyon.org.uk> (raw)
In-Reply-To: <ZbZRRBP453U8PZ8a@codewreck.org>
Dominique Martinet <asmadeus@codewreck.org> wrote:
> I was going to say we probably need to filter it out - but it looks like
> that might be netfs' job given the call trace I get:
>
> # retsnoop -T -e vfs_write -a :fs/9p/*.c -a :fs/netfs/*.c
> FUNCTION CALL TRACE RESULT DURATION
> --------------------------------- -------------------- ----------
> → vfs_write
> → netfs_unbuffered_write_iter
Yeah - I should check to see if generic_write_checks() returned 0 and skip if
it did (as does netfs_file_write_iter()).
It might also be worth doing the check before even taking any locks.
David
next prev parent reply other threads:[~2024-01-29 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 20:21 fs/9p: regression in 6.8-rc1 Eric Van Hensbergen
2024-01-27 1:53 ` Dominique Martinet
2024-01-28 13:06 ` Dominique Martinet
2024-01-29 9:20 ` David Howells [this message]
2024-01-30 15:41 ` Linux regression tracking #adding (Thorsten Leemhuis)
2024-02-18 10:10 ` Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217440.1706520008@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox