From: Christian Schoenebeck <linux_oss@crudebyte.com>
To: Dominique Martinet <asmadeus@codewreck.org>,
Eric Van Hensbergen <ericvh@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fs/9p: delete unnnecessary condition
Date: Fri, 24 Oct 2025 13:59:46 +0200 [thread overview]
Message-ID: <13655400.bYd4YqkHfl@silver> (raw)
In-Reply-To: <aPtiSJl8EwSfVvqN@stanley.mountain>
On Friday, October 24, 2025 1:26:00 PM CEST Dan Carpenter wrote:
> We already know that "retval" is negative, so there is no need to check
> again. Also the statement is not indented far enough. Delete it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Fixes: 43c36a5
Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>
Apparently a manual revert copy paste error. The rest of the revert commit
LGTM.
/Christian
> fs/9p/vfs_dentry.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/9p/vfs_dentry.c b/fs/9p/vfs_dentry.c
> index c1acbc98465d..c5bf74d547e8 100644
> --- a/fs/9p/vfs_dentry.c
> +++ b/fs/9p/vfs_dentry.c
> @@ -109,7 +109,6 @@ static int __v9fs_lookup_revalidate(struct dentry
> *dentry, unsigned int flags) p9_debug(P9_DEBUG_VFS,
> "refresh inode: dentry = %pd (%p), got error %pe\n",
> dentry, dentry, ERR_PTR(retval));
> - if (retval < 0)
> return retval;
> }
> }
next prev parent reply other threads:[~2025-10-24 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 11:26 [PATCH] fs/9p: delete unnnecessary condition Dan Carpenter
2025-10-24 11:59 ` Christian Schoenebeck [this message]
2025-10-24 13:34 ` Dominique Martinet
2025-10-25 15:39 ` Tingmao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13655400.bYd4YqkHfl@silver \
--to=linux_oss@crudebyte.com \
--cc=asmadeus@codewreck.org \
--cc=dan.carpenter@linaro.org \
--cc=ericvh@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox