From: Dominique Martinet <asmadeus@codewreck.org>
To: Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <simon.horman@corigine.com>,
v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org,
Dominique Martinet <asmadeus@codewreck.org>
Subject: [PATCH v2 0/5] Fix scan-build warnings
Date: Wed, 03 May 2023 16:49:24 +0900 [thread overview]
Message-ID: <20230427-scan-build-v2-0-bb96a6e6a33b@codewreck.org> (raw)
I ran scan-build very crudly on our source files, and there was at least
one real bug so we might as well run it once in a while, in which case
we probably ought to also fix the less important things hence this
series.
In here the first patch is a real fix and the rest is low priority, the
last one is arguably not an improvement and can be discussed (happy to
just move the 0-initializations around to variable declaration which
would also silence scan-build afaict)
Anyway, it can probably all wait until after this merge, sorry for the
timing.
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
---
Changes in v2:
- Add Fixes tag to first patch (wasn't the one suggested but a very
recent commit, still in -next)
- Fix typo in commit messages
- Link to v1: https://lore.kernel.org/r/20230427-scan-build-v1-0-efa05d65e2da@codewreck.org
---
Dominique Martinet (5):
9p: fix ignored return value in v9fs_dir_release
9p: virtio: fix unlikely null pointer deref in handle_rerror
9p: virtio: make sure 'offs' is initialized in zc_request
9p: virtio: skip incrementing unused variable
9p: remove dead stores (variable set again without being read)
fs/9p/vfs_dir.c | 5 +++--
fs/9p/vfs_inode.c | 6 ------
fs/9p/vfs_inode_dotl.c | 1 -
net/9p/client.c | 46 ++++++++++++----------------------------------
net/9p/trans_virtio.c | 8 ++++----
5 files changed, 19 insertions(+), 47 deletions(-)
---
base-commit: 21e26d5e54ab7cfe6b488fd27d4d70956d07e03b
change-id: 20230427-scan-build-d894c16fc945
Best regards,
--
Dominique Martinet | Asmadeus
next reply other threads:[~2023-05-03 7:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 7:49 Dominique Martinet [this message]
2023-05-03 7:49 ` [PATCH v2 1/5] 9p: fix ignored return value in v9fs_dir_release Dominique Martinet
2023-05-03 7:49 ` [PATCH v2 2/5] 9p: virtio: fix unlikely null pointer deref in handle_rerror Dominique Martinet
2023-05-03 7:49 ` [PATCH v2 3/5] 9p: virtio: make sure 'offs' is initialized in zc_request Dominique Martinet
2023-05-03 7:49 ` [PATCH v2 4/5] 9p: virtio: skip incrementing unused variable Dominique Martinet
2023-05-03 7:49 ` [PATCH v2 5/5] 9p: remove dead stores (variable set again without being read) Dominique Martinet
2023-05-03 8:22 ` Christian Schoenebeck
2023-05-03 8:44 ` Dominique Martinet
2023-07-20 21:26 ` [PATCH v2 0/5] Fix scan-build warnings Eric Van Hensbergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427-scan-build-v2-0-bb96a6e6a33b@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox