Linux 9p file system development
 help / color / mirror / Atom feed
From: skvarlamatus@gmail.com
To: skvarlamatus@gmail.com, ericvh@kernel.org, lucho@ionkov.net,
	asmadeus@codewreck.org, linux_oss@crudebyte.com,
	stefanha@redhat.com
Cc: sgarzare@redhat.com, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev
Subject: Re: [PATCH] net/9p: add vsock transport
Date: Thu, 25 Jun 2026 17:16:36 +0200	[thread overview]
Message-ID: <20260625151636.26449-1-skvarlamatus@gmail.com> (raw)
In-Reply-To: <20260527073447.86538-1-skvarlamatus@gmail.com>

Thank you all for reviewing this patch and sorry for the
late reply. I am already working on a v2.

I wanted to ask you about your opinions on the issue with
port number truncation. The port number is parsed from mount
options as u16, which is sufficient for TCP, but vsock uses u32.

I see two ways to resolve this. One is adding a new command line
option for vsock only that would be stored in a u32. The other is
changing the type of the port variable to u32, and adding a range
check for TCP.

Personally, I would lean towards the second option.

--
Matus

  parent reply	other threads:[~2026-06-25 15:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27  7:34 [PATCH] net/9p: add vsock transport skvarlamatus
2026-05-28 15:39 ` Stefan Hajnoczi
2026-05-29  3:01 ` Dominique Martinet
2026-06-25 15:16 ` skvarlamatus [this message]
2026-06-25 20:53   ` Dominique Martinet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260625151636.26449-1-skvarlamatus@gmail.com \
    --to=skvarlamatus@gmail.com \
    --cc=asmadeus@codewreck.org \
    --cc=ericvh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=v9fs@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox