From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42E1213BACE for ; Tue, 16 Apr 2024 23:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308608; cv=none; b=qebPCO3zt6/37Nu2HmKqMNe2U1cHVEPI0IPL6Lh2Rbo+St49mHK7FrlYhaRemvtuIvBEjO8U6jlCM/DY0jXRj/rcD6DNpWwKD04Q+LBG8sbp4ahhfbEhXxFVOZ+21WoBflte+8b0QzhBZnnbSBGd4hNZsynJhDGgmLUpVGiOL6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308608; c=relaxed/simple; bh=DNSKqIczlyBwuQ67ZFkxtx1MZSnOD27Vgyxg6uryKIE=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=iI1RUIHMRUOyak/J037JPsOW0Hq5hh2jDI3Y/dn6yOcqEWKliSoJzKOz+op4q2dSizxKH2ENJ9tHTNw5g1+IO+xmiSDJz0NgHcVFw22smNFWOlcPVUQfUzNgUBm6qLCEx06jdPdavxF9HC5cZPw8T8OU5XffSq7A5EdxbiWnOdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CXnICOXs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CXnICOXs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713308605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=omkePlcDB8enwqcFXRle7B6BhP/V3w40pUO+LmEoCqU=; b=CXnICOXset/O5ka+48NCntWsYHEsgTbC7TdL21LKbjscSHVW3BHEj6YpZgIXN0LzMmONZX W1hLCPUvtP+vpCXpzSj5pp4Renqs8WWhozcZwOB7h9yeqsMrXhl3d0oAjs+IETY1AyK3Vw x+QJXv1+HnH97heZSTrqJCttdCD+B8Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-HZB_5gEsP8-Mrh_g6kWHzA-1; Tue, 16 Apr 2024 19:03:20 -0400 X-MC-Unique: HZB_5gEsP8-Mrh_g6kWHzA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ADE98803513; Tue, 16 Apr 2024 23:03:18 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C3961BDAA; Tue, 16 Apr 2024 23:03:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <9b7de2417924192fb411744171015877c1d4c677.camel@kernel.org> References: <9b7de2417924192fb411744171015877c1d4c677.camel@kernel.org> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-12-dhowells@redhat.com> To: Jeff Layton Cc: dhowells@redhat.com, Christian Brauner , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH 11/26] 9p: Use alternative invalidation to using launder_folio Precedence: bulk X-Mailing-List: v9fs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2756051.1713308590.1@warthog.procyon.org.uk> Date: Wed, 17 Apr 2024 00:03:10 +0100 Message-ID: <2756052.1713308590@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Jeff Layton wrote: > Shouldn't this include a call to filemap_invalidate_inode? Is just > removing launder_folio enough to do this? Good point. netfs_unbuffered_write_iter() calls kiocb_invalidate_pages() - which uses invalidate_inode_pages2_range() to discard the pagecache. It should probably use filemap_invalidate_inode() instead. David