From: David Howells <dhowells@redhat.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: dhowells@redhat.com,
Christian Schoenebeck <linux_oss@crudebyte.com>,
Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Chris Arges <carges@cloudflare.com>,
v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: 9p read corruption of mmaped content (Was: [PATCH] 9p/virtio: restrict page pinning to user_backed_iter() iovec)
Date: Fri, 19 Dec 2025 14:01:57 +0000 [thread overview]
Message-ID: <818489.1766152917@warthog.procyon.org.uk> (raw)
In-Reply-To: <aUTP9oCJ9RkIYtKQ@codewreck.org>
Dominique Martinet <asmadeus@codewreck.org> wrote:
> netfs_collect_folio: R=00001b55 ix=00003 r=3000-4000 t=3000/5fb2
> netfs_folio: i=157f3 ix=00003-00003 read-done
> netfs_folio: i=157f3 ix=00003-00003 read-unlock
> netfs_collect_folio: R=00001b55 ix=00004 r=4000-5000 t=4000/5fb2
> netfs_folio: i=157f3 ix=00004-00004 read-done
> netfs_folio: i=157f3 ix=00004-00004 read-unlock
> netfs_collect_folio: R=00001b55 ix=00005 r=5000-5fb2 t=5000/5fb2
> netfs_folio: i=157f3 ix=00005-00005 read-done
> netfs_folio: i=157f3 ix=00005-00005 read-unlock
> ...
> netfs_collect_stream: R=00001b55[0:] cto=5fb2 frn=ffffffff
> netfs_collect_state: R=00001b55 col=5fb2 cln=6000 n=c
> netfs_collect_stream: R=00001b55[0:] cto=5fb2 frn=ffffffff
> netfs_collect_state: R=00001b55 col=5fb2 cln=6000 n=8
> ...
> netfs_sreq: R=00001b55[2] ZERO SUBMT f=000 s=5fb2 0/4e s=0 e=0
> netfs_sreq: R=00001b55[2] ZERO TERM f=102 s=5fb2 4e/4e s=5 e=0
This would seem to show a problem, if not the problem.
We unlocked page ix=00005 before doing the ZERO subreq that clears the page
tail. That shouldn't have happened since the collection point hasn't reached
the end of the folio yet.
David
next prev parent reply other threads:[~2025-12-19 14:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 21:04 [PATCH] 9p/virtio: restrict page pinning to user_backed_iter() iovec Dominique Martinet via B4 Relay
2025-12-10 4:21 ` Matthew Wilcox
2025-12-10 6:04 ` Christoph Hellwig
2025-12-10 7:38 ` asmadeus
2025-12-10 8:32 ` Christoph Hellwig
2025-12-13 13:28 ` asmadeus
2025-12-15 5:55 ` Christoph Hellwig
2025-12-15 7:34 ` Dominique Martinet
2025-12-15 11:16 ` Christian Schoenebeck
2025-12-15 14:37 ` Christoph Hellwig
2025-12-19 12:03 ` David Howells
2025-12-19 12:00 ` David Howells
2025-12-19 11:26 ` David Howells
2025-12-10 13:33 ` Christian Schoenebeck
2025-12-17 13:41 ` Christian Schoenebeck
2025-12-17 21:49 ` asmadeus
2025-12-18 14:21 ` asmadeus
2025-12-18 15:14 ` Christian Schoenebeck
2025-12-18 23:14 ` asmadeus
2025-12-19 4:09 ` 9p read corruption of mmaped content (Was: [PATCH] 9p/virtio: restrict page pinning to user_backed_iter() iovec) Dominique Martinet
2025-12-19 11:53 ` Dominique Martinet
2025-12-19 13:46 ` Dominique Martinet
2025-12-19 14:01 ` David Howells [this message]
2025-12-19 12:06 ` [PATCH] 9p/virtio: restrict page pinning to user_backed_iter() iovec David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=818489.1766152917@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=carges@cloudflare.com \
--cc=ericvh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox