From: Joshua Murphy <joshuamurphy@posteo.net>
To: Daniel Verkamp <dverkamp@chromium.org>
Cc: ericvh@kernel.org, lucho@ionkov.net, asmadeus@codewreck.org,
linux_oss@crudebyte.com, v9fs@lists.linux.dev
Subject: Re: [PATCH v2] net/9p/fd: support ipv6 for trans=tcp
Date: Sat, 18 Jan 2025 01:23:52 +0000 [thread overview]
Message-ID: <87jzasgbiv.fsf@posteo.net> (raw)
In-Reply-To: <CABVzXAmxVAe-9wEy3QD6iZtA+pXj5_cVcDob06WNTC5conmmWw@mail.gmail.com> (Daniel Verkamp's message of "Fri, 17 Jan 2025 14:50:47 -0800")
> It looks like inet_addr_is_any() checks the current sin_addr/sin6_addr
> of a sockaddr, but does not change it, so this doesn't seem quite
> right (its only effect is to return a bool, which is discarded here).
Huh, I’ll definitely fix that.
For some reason I must’ve thought it changed the addresses rather than
checking them.
> inet_pton_with_scope() appears to unconditionally dereference its
> `src` parameter (`addr` in the call above), so the `addr == NULL`
> check is too late.
I’ll put it in a separate check before the inet one.
Thanks,
--
Joshua Murphy
joshuamurphy@posteo.net
next prev parent reply other threads:[~2025-01-18 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 21:44 [PATCH v2] net/9p/fd: support ipv6 for trans=tcp Joshua Murphy
2025-01-17 22:50 ` Daniel Verkamp
2025-01-18 1:23 ` Joshua Murphy [this message]
2025-01-18 7:27 ` asmadeus
2025-01-18 18:54 ` Joshua Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzasgbiv.fsf@posteo.net \
--to=joshuamurphy@posteo.net \
--cc=asmadeus@codewreck.org \
--cc=dverkamp@chromium.org \
--cc=ericvh@kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox