From: Joshua Murphy <joshuamurphy@posteo.net>
To: asmadeus@codewreck.org
Cc: ericvh@kernel.org, lucho@ionkov.net, linux_oss@crudebyte.com,
v9fs@lists.linux.dev
Subject: Re: [PATCH] net/9p/fd: support ipv6 for trans=tcp
Date: Fri, 17 Jan 2025 17:46:45 +0000 [thread overview]
Message-ID: <87jzatl4e2.fsf@posteo.net> (raw)
In-Reply-To: <Z4liFG9zHHHslkp6@codewreck.org> (asmadeus@codewreck.org's message of "Fri, 17 Jan 2025 04:46:28 +0900")
> That memset is for sockaddr size, should it be for sockaddr_storage?
Yeah, it probably should be.
Do you think it would make more sense to only initialize the
sockaddr_storage as later suggested instead of using the memset?
> not a new problem but I don't see this being initialized to zero either,
> I'm not sure if there are cases where that can cause problems but it
> might be just as well to init `stor = { 0 };` or equivalent just in
> case?
Makes sense, will do.
> Could you try to get rid of valid_ipaddr4 and call inet_pton_with_scope
> with AF_UNSPEC directly?
That would definitely be the more correct solution, I think.
Originally, I was trying not to change the code too much, but I guess if
I’m changing it I might as well go all the way :D.
--
Joshua Murphy
joshuamurphy@posteo.net
prev parent reply other threads:[~2025-01-17 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 16:07 [PATCH] net/9p/fd: support ipv6 for trans=tcp Joshua Murphy
2025-01-16 19:46 ` asmadeus
2025-01-17 17:46 ` Joshua Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzatl4e2.fsf@posteo.net \
--to=joshuamurphy@posteo.net \
--cc=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox