Re: [PATCH v3] net/9p/fd: support ipv6 for trans=tcp

[asmadeus@codewreck.org]

Joshua Murphy wrote on Sat, Jan 18, 2025 at 07:12:36PM +0000:
> Allows specifying an IPv6 address when mounting a remote 9p file system.
> 
> Signed-off-by: Joshua Murphy <joshuamurphy@posteo.net>

Thank you!

I don't have any problem with this, I need to find some time to take the
dust off my 9p tcp server setup to try this out.

Meanwhile I should have tried earlier but checkpatch has a few qualms
about style; if you send a v4 for any other reason please try running it
yourself.
--------
$ git show --format=email | ./scripts/checkpatch.pl -
CHECK: No space is necessary after a cast
#56: FILE: net/9p/trans_fd.c:965:
+               ((struct sockaddr_in *) &stor)->sin_addr.s_addr = htonl(INADDR_ANY);

CHECK: No space is necessary after a cast
#58: FILE: net/9p/trans_fd.c:967:
+               ((struct sockaddr_in6 *) &stor)->sin6_addr = in6addr_any;

CHECK: No space is necessary after a cast
#63: FILE: net/9p/trans_fd.c:970:
+                       ((struct sockaddr_in *) &stor)->sin_port = htons((ushort)port);

CHECK: No space is necessary after a cast
#65: FILE: net/9p/trans_fd.c:972:
+                       ((struct sockaddr_in6 *) &stor)->sin6_port = htons((ushort)port);

CHECK: No space is necessary after a cast
#66: FILE: net/9p/trans_fd.c:973:
+               err = kernel_bind(sock, (struct sockaddr *) &stor, sizeof(stor));

CHECK: Comparison to NULL could be written "!addr"
#89: FILE: net/9p/trans_fd.c:993:
+       if (addr == NULL)

WARNING: braces {} are not necessary for single statement blocks
#95: FILE: net/9p/trans_fd.c:999:
+       if (err < 0) {
+               return err;
+       }

CHECK: No space is necessary after a cast
#117: FILE: net/9p/trans_fd.c:1026:
+                                              (struct sockaddr *) &stor,
--------

(Some aren't new and I don't mind too much, but most are on new code)


I can't make any promise about testing but will try to find time around
next weekend, after which the patch will slowly make its way in next
cycle.
-- 
Dominique