Re: [PATCH v2] net/9p/fd: support ipv6 for trans=tcp

Joshua Murphy
2025-01-18T01:23:58Z

> It looks like inet_addr_is_any() checks the current sin_addr/sin6_addr
> of a sockaddr, but does not change it, so this doesn't seem quite
> right (its only effect is to return a bool, which is discarded here).

Huh, I’ll definitely fix that.
For some reason I must’ve thought it changed the addresses rather than
checking them.

> inet_pton_with_scope() appears to unconditionally dereference its
> `src` parameter (`addr` in the call above), so the `addr == NULL`
> check is too late.

I’ll put it in a separate check before the inet one.

Thanks,
--
Joshua Murphy
joshuamurphy@posteo.net