Re: [PATCH v2] net/9p/fd: support ipv6 for trans=tcp

asmadeus
2025-01-18T07:28:11Z

Joshua Murphy wrote on Fri, Jan 17, 2025 at 09:44:46PM +0000:
> Allows specifying an IPv6 address when mounting a remote 9p file system.

Thanks for the v2!

Daniel beat me to the important bits, just a couple more.

> - if (addr == NULL || valid_ipaddr4(addr) < 0)

valid_ipaddr4 is no longer used so please also remove the function
definition just above as well

> - return -EINVAL;
> + sprintf(port_str, "%u", opts.port);

Oh, I hadn't realized this takes a string..

The previous string -> u16 conversion into opts.port happens in the same
file (parse_opts), and trans_opts is only used to print options in
/proc/mount later so can be made a char * as well, but that is code
cleanup that can (and probably should) be done in a separate patch.
Let's keep the sprintf here and I'll try to find time for that later
unless you want to do it.

Cheers,
--
Dominique Martinet | Asmadeus