From: Dominique Martinet <asmadeus@codewreck.org>
To: Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
Robert Morris <rtm@mit.edu>
Subject: Re: [PATCH v2] 9p/net: fix improper handling of bogus negative read/write replies
Date: Mon, 17 Mar 2025 06:38:18 +0900 [thread overview]
Message-ID: <Z9dEytS7GXL87OVP@codewreck.org> (raw)
In-Reply-To: <20250317-9p_unsigned_rw-v2-1-9d7a94a916ae@codewreck.org>
Dominique Martinet wrote on Mon, Mar 17, 2025 at 06:32:56AM +0900:
> @@ -1633,7 +1634,7 @@ p9_client_write(struct p9_fid *fid, u64 offset, struct iov_iter *from, int *err)
> if (count < rsize)
> rsize = count;
>
> - p9_debug(P9_DEBUG_9P, ">>> TWRITE fid %d offset %llu count %d (/%d)\n",
> + p9_debug(P9_DEBUG_9P, ">>> TWRITE fid %d offset %llu count %zu (/%zu)\n",
> fid->fid, offset, rsize, count);
I obviously ran make W=1 after sending this and noticed I forgot to
update the format fields, let's pretend this was %u for rsize (same
below)
--
Dominique
next prev parent reply other threads:[~2025-03-16 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 21:32 [PATCH v2] 9p/net: fix improper handling of bogus negative read/write replies Dominique Martinet
2025-03-16 21:38 ` Dominique Martinet [this message]
2025-03-19 9:20 ` Christian Schoenebeck
2025-03-19 9:42 ` Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9dEytS7GXL87OVP@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=rtm@mit.edu \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox