From: Dominique Martinet <asmadeus@codewreck.org>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Christian Schoenebeck <linux_oss@crudebyte.com>,
Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org,
syzbot+56fdf7f6291d819b9b19@syzkaller.appspotmail.com,
syzbot+a83dc51a78f0f4cf20da@syzkaller.appspotmail.com,
Pavel Skripkin <paskripkin@gmail.com>
Subject: Re: [PATCH] fs: 9p: avoid warning during xattr allocation
Date: Mon, 4 Mar 2024 22:09:22 +0900 [thread overview]
Message-ID: <ZeXIAmbZmENoKr2f@codewreck.org> (raw)
In-Reply-To: <20240202121319.21743-1-pchelkin@ispras.ru>
Fedor Pchelkin wrote on Fri, Feb 02, 2024 at 03:13:17PM +0300:
> An invalid server may reply with an xattr size which still fits into
> ssize_t but is large enough to cause splat during kzalloc().
Ah, sorry for not replying to this earlier.. and I had forgotten about
it when something similar came up just now.
I've submitted a patch to limit such allocations to 64k:
https://lkml.kernel.org/r/20240304-xattr_maxsize-v1-1-322357ec6bdf@codewreck.org
Would you agree this makes this patch obsolete?
I'll go ahead and add the reported-by/closes you cited in this mail to
my commit.
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2024-03-04 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 12:13 [PATCH] fs: 9p: avoid warning during xattr allocation Fedor Pchelkin
2024-03-04 13:09 ` Dominique Martinet [this message]
2024-03-04 21:19 ` Fedor Pchelkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeXIAmbZmENoKr2f@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=ericvh@kernel.org \
--cc=jvrao@linux.vnet.ibm.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=lvc-project@linuxtesting.org \
--cc=paskripkin@gmail.com \
--cc=pchelkin@ispras.ru \
--cc=syzbot+56fdf7f6291d819b9b19@syzkaller.appspotmail.com \
--cc=syzbot+a83dc51a78f0f4cf20da@syzkaller.appspotmail.com \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox