From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 357E22C0278 for ; Tue, 14 Oct 2025 20:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760474756; cv=none; b=UzR6MCM2ZPL1RlEeQBR8b7LVF1oKF7xitwW1VSPStuVOzK8lwtBlxlMH8/2lYFql2C9Zpvblc8g5fffKCgDY8RE6X4RSMcH3hyEscQOmCxk8sZtTsyvn/8363DL/z4VzNrdO+3w3ir5PPi/IDvhudmGyXHgQV9jM5R2TN64OEio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760474756; c=relaxed/simple; bh=mLMiOvkuQ1waPsYJBAJdPUyickusJQ8ORxj4y3Zep3Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BP+K++VmIgvC14Eu0ip+2aTyDEZRdGmaH05GvE+D2OCdMUZh+6ylst0qTuHQe7t3otGXpBgo1bovf9KvoAhw/y2QlSjysTY5uVEYCtR3dYNb+uC0VGWqyMcal4owdbtPwPFuFvXXOD8yhvO0KseNrPOhn2p3op1uVvex5PsT4+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=srjW0sRV; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="srjW0sRV" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-32ed19ce5a3so5205167a91.0 for ; Tue, 14 Oct 2025 13:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1760474754; x=1761079554; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ProMLWdJiYhd+ReUg4Q/nfu5OGup3NKBCnvPEIlS8hk=; b=srjW0sRVUYqmtK+ZSoMIdjhhPUxzBaO40zIjQzPVsYAcGpkffC/OwGwZlsPK3EV3Qr Df0I//tFySUBtMsJdbts2zToYSGfUuQRmaUYxOPcvJMxbDXzGxYTjPrK+besiQJSVhpW g33T59dNLzCrsq2smo3W9HBZUw5PNIJjg72wq42P4gVEFKax3XD8Jr6QGgmQt6V/aLwE oZbHQ1TD+tX2cUGt9iw1iGDxQD9KSr+B8OEyqvMAa39cAdL0HPeRzGzGfLRyQJjPVLyF oG2NzTUuDUHb+XXz2jmY4H1iU4AordQvLQGlnICMLri1HjY9ZnXrZjbUsrkKUujoNq0l cazg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760474754; x=1761079554; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ProMLWdJiYhd+ReUg4Q/nfu5OGup3NKBCnvPEIlS8hk=; b=RRehih2H+QXiZRhOl0YsmZgA9ACIU8EEi01s6zPbJp5+y1n38o+61NcBYRglCZCVik GgpzUAce7YOp8AlAHrDHFaO5IXVEq3eKEwAz08qRn6EHhbo9nqaTEK3SH78OtDurXxrY 5oSwEVarQlEV0mlOS8LsapSgdilRhi2weN+RuHc6CQqdyVxlCDAUwInQSv1GtJs+ggbT I89VDnlRLX624x7rWrdRm3KEM+GPcCcK7JFzyYILmGZHmK16JMX2DK5jEiDJ14xx8I2u 1+5vLgbbQ9kzi8hMaZ7Jcfepdrg8tPi68OCwKVDUjAOmz+8IOwZi14dw15nFTlH+VefK tokA== X-Forwarded-Encrypted: i=1; AJvYcCWhJMzmGj70H8YtRA+m0I10Zdyql0oLJJ3xYjUJeNgvQf+l3BgQu0+gRPIOU59B+oMQbN0y@lists.linux.dev X-Gm-Message-State: AOJu0Yzl6fpGMUk597v2XL5UGoNZPHYrnZMNd69cY2TcqgZJM/XrNVLl xE7Jhrx7fnPat5RCeKQe9HT4cv/qXGzf7951rw8lPcMB3fagxlmxVb6GgUvmCulbyAo= X-Gm-Gg: ASbGncs520yUtC5RLUUtAjq126sGajfJFUxgJEM7p03gBgfOFXKYG94PY+AVtVXx+mA 1fxSMAzqWL0kCRBXHMZRnFirC8xBPtMK2sPxtPUHfDkx03N3bB6/2Lgk9X+hC2zqRyuWFvKLD+l rSYcrW+0TstnNIafAe4eDx9v44LntRHmGFMTekHuMt485p1v1Rp/V4IP1tf3SoyRmQcO/nMexVY iPdvhdtEdwDgjtawJ8TcA5hTEkIeRhx4cAKK6B5Fi4b7vAXmEB6uaAnHJu4fC/3SlqSJ3HLjdR/ v5vdkVNMv1XOI9V98SvIueWSIAqKMEuJywXr5uKSzwo7uE2RSwQbQK0ohlk/pXBtDp9pvex20rr MJ/pjBPNqBgyIuGeIT6sdcHU4mRJysi88Q6VrhCfstQWFSZEVUCsKdCuzEXMBsmoKhdUpsj4sg6 2VMN+LVhn/7OMf/W3h X-Google-Smtp-Source: AGHT+IEha/464YLIDe1S05FMmmIwJiiHJqNozxP/E/7ahWiUSHSloNCgr/S9uHudRNKH/rfSTuG4WQ== X-Received: by 2002:a17:90b:3947:b0:31e:c95a:cef8 with SMTP id 98e67ed59e1d1-33b5139a259mr32044929a91.32.1760474754350; Tue, 14 Oct 2025 13:45:54 -0700 (PDT) Received: from dread.disaster.area (pa49-180-91-142.pa.nsw.optusnet.com.au. [49.180.91.142]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33b62631266sm16839994a91.3.2025.10.14.13.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 13:45:53 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.98.2) (envelope-from ) id 1v8lu3-0000000Es6g-0Y5G; Wed, 15 Oct 2025 07:45:51 +1100 Date: Wed, 15 Oct 2025 07:45:51 +1100 From: Dave Chinner To: Jan Kara Cc: Christoph Hellwig , Damien Le Moal , "Matthew Wilcox (Oracle)" , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Chris Mason , David Sterba , Mark Fasheh , Joel Becker , Joseph Qi , Alexander Viro , Christian Brauner , Josef Bacik , linux-block@vger.kernel.org, v9fs@lists.linux.dev, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@lists.linux.dev, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 06/10] mm,btrfs: add a filemap_fdatawrite_kick_nr helper Message-ID: References: <20251013025808.4111128-1-hch@lst.de> <20251013025808.4111128-7-hch@lst.de> <74593bac-929b-4496-80e0-43d0f54d6b4c@kernel.org> <4bcpiwrhbrraau7nlp6mxbffprtnlv3piqyn7xkm7j2txxqlmn@3knyilc526ts> <20251014044723.GA30978@lst.de> Precedence: bulk X-Mailing-List: v9fs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Oct 14, 2025 at 11:33:26AM +0200, Jan Kara wrote: > On Tue 14-10-25 06:47:23, Christoph Hellwig wrote: > > On Mon, Oct 13, 2025 at 01:58:15PM +0200, Jan Kara wrote: > > > I don't love filemap_fdatawrite_kick_nr() either. Your > > > filemap_fdatawrite_nrpages() is better but so far we had the distinction > > > that filemap_fdatawrite* is for data integrity writeback and filemap_flush > > > is for memory cleaning writeback. And in some places this is important > > > distinction which I'd like to keep obvious in the naming. So I'd prefer > > > something like filemap_flush_nrpages() (to stay consistent with previous > > > naming) or if Christoph doesn't like flush (as that's kind of overloaded > > > word) we could have filemap_writeback_nrpages(). > > > > Not a big fan of flush, but the important point in this series is > > to have consistent naming. > > I fully agree on that. *nod* > > If we don't like the kick naming we should standardize on _flush (or > > whatever) and have the _range and _nrpages variants of whatever we pick > > for the base name. > > > > Anyone with strong feelings and or good ideas about naming please speak > > up now. > > I agree with either keeping filemap_flush* or using filemap_writeback* (and > renaming filemap_flush to filemap_writeback). I'd prefer filemap_flush* because most people are already familiar with that naming and the expected semnatics. But I could live with filemap_writebacki*, too. Both are better than "kick", IMO. -Dave. -- Dave Chinner david@fromorbit.com