From: Dominique Martinet <asmadeus@codewreck.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, ericvh@kernel.org,
lucho@ionkov.net, linux_oss@crudebyte.com, eadavis@qq.com,
Remi Pommarel <repk@triplefau.lt>
Subject: Re: [PATCH V3 5/4] 9p: fix cache option printing in v9fs_show_options
Date: Thu, 4 Dec 2025 00:04:21 +0900 [thread overview]
Message-ID: <aTBRdeUvqF4rX778@codewreck.org> (raw)
In-Reply-To: <c1d0a33e-768a-45ee-b870-e84c25b04896@redhat.com>
Eric Sandeen wrote on Tue, Dec 02, 2025 at 07:09:42PM -0600:
> >> - seq_printf(m, ",cache=%x", v9ses->cache);
> >> + seq_printf(m, ",cache=0x%x", v9ses->cache);
> >
> > What's wrong with "cache=%#x"?
>
> Nothing, presumably - I did not know this existed TBH.
>
> (looks like that usage is about 1/10 of 0x%x currently)
I don't have any preference here, but I've folded in %#x when applying
because why not -- I've been seeing it slightly more often lately so I
guess it's the "modern way" of doing this.
(I got curious and this SPECIAL flag in lib/vsprintf.c has been around
since at least the first 2.6.12-rc2 git commit, so there's nothing new
about it and I suspect it'll never quite be popular...)
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2025-12-03 15:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 21:36 [PATCH V3 0/4] 9p: Convert to the new mount API Eric Sandeen
2025-10-10 21:36 ` [PATCH V3 1/4] fs/fs_parse: add back fsparam_u32hex Eric Sandeen
2025-10-10 21:36 ` [PATCH V3 2/4] net/9p: move structures and macros to header files Eric Sandeen
2025-10-10 21:36 ` [PATCH V3 3/4] 9p: create a v9fs_context structure to hold parsed options Eric Sandeen
2025-10-10 21:36 ` [PATCH V3 4/4] 9p: convert to the new mount API Eric Sandeen
2025-10-13 10:26 ` Dominique Martinet
2025-10-13 18:46 ` Eric Sandeen
2025-10-13 19:04 ` Dominique Martinet
2025-11-26 20:16 ` Remi Pommarel
2025-11-26 22:43 ` Dominique Martinet
2025-12-01 22:36 ` Eric Sandeen
2025-12-02 1:04 ` Dominique Martinet
2025-12-02 22:12 ` Eric Sandeen
2025-12-03 15:13 ` Dominique Martinet
2025-12-03 16:23 ` Eric Sandeen
2025-12-05 11:53 ` Remi Pommarel
2025-12-05 12:56 ` Dominique Martinet
2025-12-02 22:30 ` [PATCH V3 5/4] 9p: fix cache option printing in v9fs_show_options Eric Sandeen
2025-12-02 23:13 ` Al Viro
2025-12-03 1:09 ` Eric Sandeen
2025-12-03 15:04 ` Dominique Martinet [this message]
2025-12-03 18:04 ` Al Viro
2025-12-02 22:34 ` [PATCH V3 6/4] 9p: fix new mount API cache option handling Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTBRdeUvqF4rX778@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=eadavis@qq.com \
--cc=ericvh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=repk@triplefau.lt \
--cc=sandeen@redhat.com \
--cc=v9fs@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox