From: Dominique Martinet <asmadeus@codewreck.org>
To: Vasiliy Kovalev <kovalev@altlinux.org>
Cc: Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] net/9p: fix infinite loop in p9_client_rpc on fatal signal
Date: Mon, 22 Jun 2026 10:42:40 +0900 [thread overview]
Message-ID: <ajiTEOQfjcVvnG-t@codewreck.org> (raw)
In-Reply-To: <efc4fa29-eae1-0b49-1550-b5dd3b7e28b7@basealt.ru>
Vasiliy Kovalev wrote on Mon, Jun 22, 2026 at 01:06:21AM +0300:
> The deterministic path is the syzkaller C reproducer:
> https://syzkaller.appspot.com/x/repro.c?x=156aa534580000
>
> [...]
>
> dmesg fires on every iteration:
Thanks for the quick reply, I've confirmed this repro "works", as in gets
out of the loop as expected.
> On a real server I couldn't reproduce this by hand. The reproducer
> hits the branch deterministically (logs above); why hand-issued
> SIGKILLs don't get there is a kernel signal-delivery question
> outside the path this patch touches, and I didn't dig into it.
Right, from my added logs, when doing it "by hand", I don't think the
thread goes out of the wait_event_killable() the second time around.
I agree it's slightly out of scope, but any behaviour we don't
understand is something that could be subject to change, so I'll try to
dig a bit further as time allows.
> Feel free to revert if anything turns up in the next weeks.
Thanks, for now Linus took the patch, I'll let you know if there is any
change.
--
Dominique Martinet | Asmadeus
prev parent reply other threads:[~2026-06-22 1:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 15:52 [PATCH] net/9p: fix infinite loop in p9_client_rpc on fatal signal Vasiliy Kovalev
2026-04-16 1:41 ` Dominique Martinet
2026-04-16 12:49 ` Vasiliy Kovalev
2026-04-16 22:52 ` Dominique Martinet
2026-04-19 8:22 ` Vasiliy Kovalev
2026-05-19 12:35 ` Dominique Martinet
2026-06-21 13:00 ` Dominique Martinet
2026-06-21 22:06 ` Vasiliy Kovalev
2026-06-22 1:42 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajiTEOQfjcVvnG-t@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=kovalev@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=lvc-project@linuxtesting.org \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox