From: Stefano Garzarella <sgarzare@redhat.com>
To: skvarlamatus@gmail.com
Cc: asmadeus@codewreck.org, ericvh@kernel.org,
linux-kernel@vger.kernel.org, linux_oss@crudebyte.com,
lucho@ionkov.net, stefanha@redhat.com, v9fs@lists.linux.dev
Subject: Re: [PATCH v2] net/9p: add vsock transport
Date: Fri, 3 Jul 2026 16:39:41 +0200 [thread overview]
Message-ID: <akfJDhVJKMXiX4KH@sgarzare-redhat> (raw)
In-Reply-To: <20260703143125.45423-1-skvarlamatus@gmail.com>
On Fri, Jul 03, 2026 at 04:31:25PM +0200, skvarlamatus@gmail.com wrote:
>On Fri, Jul 03, 2026 at 09:12 +0000, sgarzare@redhat.com wrote:
>> >The privport mount option is not currently supported for vsock and
>> >returns -EOPNOTSUPP if specified.
>>
>> Why not?
>
>The existing p9_bind_privport() implementation is TCP-specific
>(uses inet_pton and struct sockaddr_in), so it cannot be reused
>for vsock directly. Per Stefan Hajnoczi's suggestion, I opted to
>reject the option cleanly for now rather than leave it silently
Ah, I see now. Sorry, I didn't look at the v1.
>ignored. Support can be added in a follow-up if needed.
I'd add a comment in the code to explain that, maybe with a TODO label.
Because initially I thought it was not applicable to AF_VSOCK sockets
for some reason related to he socket family.
Thanks,
Stefano
prev parent reply other threads:[~2026-07-03 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 15:59 [PATCH v2] net/9p: add vsock transport skvarlamatus
2026-07-03 5:41 ` Stefan Hajnoczi
[not found] ` <CANG_AsJtiN+31UCEZDSRX5ckq10vW-Qw7gjcBcB+feDZA7rgww@mail.gmail.com>
2026-07-03 14:16 ` Dominique Martinet
2026-07-03 14:58 ` skvarlamatus
2026-07-03 14:16 ` Matus Skvarla
2026-07-03 14:39 ` Matus Skvarla
2026-07-03 9:12 ` Stefano Garzarella
2026-07-03 14:31 ` skvarlamatus
2026-07-03 14:39 ` Stefano Garzarella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akfJDhVJKMXiX4KH@sgarzare-redhat \
--to=sgarzare@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=skvarlamatus@gmail.com \
--cc=stefanha@redhat.com \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox