From: sashiko-bot@kernel.org
To: "Dominique Martinet" <asmadeus@codewreck.org>
Cc: v9fs@lists.linux.dev
Subject: Re: [PATCH] 9p: optimize p9_fcall struct
Date: Thu, 29 Oct 2026 06:03:10 +0000 [thread overview]
Message-ID: <sashiko-outbox-188787@kernel.org> (raw)
In-Reply-To: <20261029060014.3-1-asmadeus@codewreck.org>
> p9_fcall has a 1 byte hole followed by more data and then a single byte
> element:
>
> struct p9_fcall {
> u32 size; /* 0 4 */
> u8 id; /* 4 1 */
>
> /* XXX 1 byte hole, try to pack */
>
> u16 tag; /* 6 2 */
> size_t offset; /* 8 8 */
> size_t capacity; /* 16 8 */
> struct kmem_cache * cache; /* 24 8 */
> u8 * sdata; /* 32 8 */
> bool zc; /* 40 1 */
> [ ... ]
>
> This in turn also makes p9_req_t 16 bytes smaller (152 -> 136) as it
> contains two of these.
>
> Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029060014.3-1-asmadeus@codewreck.org?part=1
prev parent reply other threads:[~2026-10-29 6:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 6:00 [PATCH] 9p: optimize p9_fcall struct Dominique Martinet
2026-10-29 6:03 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-188787@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox