From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Max Gurtovoy <mgurtovoy@nvidia.com>,
virtio-comment@lists.oasis-open.org, stefanha@redhat.com,
eperezma@redhat.com, oren@nvidia.com
Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering
Date: Mon, 16 Aug 2021 10:40:16 -0400 [thread overview]
Message-ID: <20210816103945-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <874kbpvkpn.fsf@redhat.com>
On Mon, Aug 16, 2021 at 10:48:36AM +0200, Cornelia Huck wrote:
> On Thu, Aug 12 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
>
> > On 8/10/2021 9:44 AM, Cornelia Huck wrote:
> >> On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
> >>
> >>> This should have been updated during VIRTIO_F_NOTIFICATION_DATA and
> >>> VIRTIO_F_NOTIF_CONFIG_DATA standartization.
> >>>
> >>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> >>> ---
> >>> content.tex | 4 ++--
> >>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/content.tex b/content.tex
> >>> index 5c70a3c..e9a32fa 100644
> >>> --- a/content.tex
> >>> +++ b/content.tex
> >>> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
> >>> \begin{description}
> >>> \item[0 to 23] Feature bits for the specific device type
> >>>
> >>> -\item[24 to 37] Feature bits reserved for extensions to the queue and
> >>> +\item[24 to 39] Feature bits reserved for extensions to the queue and
> >>> feature negotiation mechanisms
> >> I'm wondering whether we should do s/reserved/used/ here?
> >
> > I'm just fixing a bug here. You can take this patch and create another
> > one with the above suggestion on top.
> >
> > I'm ok with your suggestion.
>
> So... any opinions on whether this should get a proper vote? [I won't be
> able to handle that in the next weeks. Michael?]
Feature bit numbering is an important enough matter that I'd say
let's have an issue for this please, and I will do a ballot.
> >
> >>
> >>>
> >>> -\item[38 and above] Feature bits reserved for future extensions.
> >>> +\item[40 and above] Feature bits reserved for future extensions.
> >>> \end{description}
> >>>
> >>> \begin{note}
next prev parent reply other threads:[~2021-08-16 14:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 12:45 [PATCH 1/1] Fix reserved Feature bits numbering Max Gurtovoy
2021-08-02 14:07 ` Stefan Hajnoczi
2021-08-10 6:44 ` [virtio-comment] " Cornelia Huck
2021-08-12 10:35 ` Max Gurtovoy
2021-08-16 8:48 ` Cornelia Huck
2021-08-16 14:40 ` Michael S. Tsirkin [this message]
2021-12-30 14:24 ` Max Gurtovoy
2021-12-30 14:27 ` Michael S. Tsirkin
2021-12-30 14:30 ` Max Gurtovoy
2021-12-30 14:49 ` Michael S. Tsirkin
2021-12-30 14:57 ` Max Gurtovoy
2021-12-30 17:55 ` Michael S. Tsirkin
2021-12-30 18:12 ` Michael S. Tsirkin
2022-01-03 11:13 ` Cornelia Huck
2022-01-03 16:58 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816103945-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=eperezma@redhat.com \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox