From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id AC2859840CE for ; Sun, 20 Feb 2022 13:23:37 +0000 (UTC) Date: Sun, 20 Feb 2022 08:23:26 -0500 From: "Michael S. Tsirkin" Message-ID: <20220220081428-mutt-send-email-mst@kernel.org> References: <20191125183430.1686620-1-yuri.benditovich@daynix.com> MIME-Version: 1.0 In-Reply-To: <20191125183430.1686620-1-yuri.benditovich@daynix.com> Subject: [virtio-comment] Re: [PATCH] virtio-net: (spelling only) support for receive-side scaling Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Yuri Benditovich Cc: virtio-comment@lists.oasis-open.org List-ID: On Mon, Nov 25, 2019 at 08:34:30PM +0200, Yuri Benditovich wrote: > Additional patch for previous 'v4 virtio-net: define support for > receive-side scaling' - contains only spelling fixes. > > Signed-off-by: Yuri Benditovich I just noticed that description of Device Initialization has not been updated with this patch. For example: \item Identify and initialize the receive and transmission virtqueues, up to N of each kind. If VIRTIO_NET_F_MQ feature bit is negotiated, N=\field{max_virtqueue_pairs}, otherwise identify N=1. \item If the VIRTIO_NET_F_CTRL_VQ feature bit is negotiated, identify the control virtqueue. \item Fill the receive queues with buffers: see \ref{sec:Device Types / Network Device / Device Operation / Setting Up Receive Buffers}. \item Even with VIRTIO_NET_F_MQ, only receiveq1, transmitq1 and controlq are used by default. The driver would send the VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET command specifying the number of the transmit and receive queues to use. there are some more instances of this. I created https://github.com/oasis-tcs/virtio-spec/issues/135 to track this. Also, https://github.com/oasis-tcs/virtio-spec/issues/134 since VIRTIO_NET_F_MQ name is now confusing. Yuri, could you try to address these? Thanks! -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/