From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id A61039865FA for ; Tue, 28 Feb 2023 07:49:49 +0000 (UTC) Date: Tue, 28 Feb 2023 02:49:41 -0500 From: "Michael S. Tsirkin" Message-ID: <20230228024829-mutt-send-email-mst@kernel.org> References: <20230226093724.44717-1-hengqi@linux.alibaba.com> <1ba1c6ed-6a3f-21e6-dbb2-0f1a1ed9ca62@linux.alibaba.com> <20230227151420-mutt-send-email-mst@kernel.org> <46d5248b-1632-22b1-03b0-7ca64d536f04@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <46d5248b-1632-22b1-03b0-7ca64d536f04@linux.alibaba.com> Subject: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Heng Qi Cc: Alvaro Karsz , virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, Parav Pandit , David Edmondson , Jason Wang , Xuan Zhuo List-ID: On Tue, Feb 28, 2023 at 10:41:18AM +0800, Heng Qi wrote: > > The problem is the global qualifier. And it's not even global - > > there are two sets for rx and for tx and does not apply to cvq at all. > > How about "RX/TX coalescing parameters"? > > As Parav suggested, we probably don't need to mention "global > values/coalescing parameters" since this values/parameters are the ones set > by CTRL_NOTF_COAL_RX/TX_SET. > > Just like this: > " > After disabling and re-enabling a virtuqueue, the device MUST revert to > coalescing parameters to the one configured using VIRTIO_NET_CTRL_NOTF_COAL. > " > > Thanks. VIRTIO_NET_CTRL_NOTF_COAL is not a thing. Let's wait for Alvaro's new patch to be merged though, see what teminology he comes up with and reuse. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/