From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74A33C77B61 for ; Sat, 8 Apr 2023 10:29:21 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 82A802AD6B for ; Sat, 8 Apr 2023 10:29:20 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 6DBFD9865F5 for ; Sat, 8 Apr 2023 10:29:20 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 5C20D986227; Sat, 8 Apr 2023 10:29:20 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 447B69865E0 for ; Sat, 8 Apr 2023 10:29:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: hidZYLtaPWuI7H1ITCI0qg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680949757; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iZgnw5diLUhtU9d6+NnDvB/R1VS5VtHDi+ViZjQUOtg=; b=XV4SCzAE+se3xVE69lWO95TatnpwCkdCxx8P0IvMkGkeFW65+HeeFZDGSkseJiyZw0 qYKP8SX8QcY4rBLC0UfEdic/WSZtS64QIoO2vtj8yTDRUCGBbPu7crkfI4XMvmn34Lqr xrZIrdk8Yy9VqNyr2sVxlL6J5sgAWoptYFvTuuymz5VXpiJbXtJZpm3bWXrn/e7O6MQl 2dwy4V/334nqRWWvTFj0lerDXGF1RnFtF1sgmf5iFr93cayF5uHTXRfX/Sdz/zHaWeuO Tk2+WPOpgkrd5661K7/pgxmSob6MZpH+KOYpnuxwHNdt8tK1R/2+ue9dupEtrhYlqTv4 t9Xw== X-Gm-Message-State: AAQBX9d8Kif6Q9/0X8wG7u+RckEQJ6I8bvVBC88MRuV0od71u44+lVoe SLVDw2jShdahmuM2f+v87qNO16E3raicq1sLCTC3M+Qp/7eMSyEu4kI9Cd3bIaC7dk92hZTZGHP hii5+WsW5rV7fuyPIjXojP5DrwfRQqjTGWA== X-Received: by 2002:a1c:ed18:0:b0:3f0:7e49:6a4d with SMTP id l24-20020a1ced18000000b003f07e496a4dmr993060wmh.11.1680949756861; Sat, 08 Apr 2023 03:29:16 -0700 (PDT) X-Google-Smtp-Source: AKy350aIXbKmJ+ZJkcRAjSO/hz7qxfcGO4XJjcbJJ4eOge24/jLLsL3Wur777f1C53sWRSkgMo9Iew== X-Received: by 2002:a1c:ed18:0:b0:3f0:7e49:6a4d with SMTP id l24-20020a1ced18000000b003f07e496a4dmr993049wmh.11.1680949756587; Sat, 08 Apr 2023 03:29:16 -0700 (PDT) Date: Sat, 8 Apr 2023 06:29:12 -0400 From: "Michael S. Tsirkin" To: Heng Qi Cc: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, Parav Pandit , Jason Wang , Yuri Benditovich , Cornelia Huck , Xuan Zhuo Message-ID: <20230408062119-mutt-send-email-mst@kernel.org> References: <20230228061309-mutt-send-email-mst@kernel.org> <25231225-59c8-91b0-e0dd-3dab8aa8164b@linux.alibaba.com> <20230308093311-mutt-send-email-mst@kernel.org> <20230309142612-mutt-send-email-mst@kernel.org> <021eeb40-aab1-07b9-cfe7-9dd61a32e0b3@linux.alibaba.com> <20230315074633-mutt-send-email-mst@kernel.org> <4b14043c-6059-1d26-060e-7dc653c4f401@linux.alibaba.com> <20230320154556-mutt-send-email-mst@kernel.org> <39f3ebf4-1141-8044-4ffc-e32e62edbb2c@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <39f3ebf4-1141-8044-4ffc-e32e62edbb2c@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Subject: Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash On Thu, Mar 30, 2023 at 08:37:21PM +0800, Heng Qi wrote: > > > 在 2023/3/21 上午3:48, Michael S. Tsirkin 写道: > > On Wed, Mar 15, 2023 at 08:55:45PM +0800, Heng Qi wrote: > > > We use the most basic GRE header fields (not NVGRE), not even optional > > > fields. > > I'd say yes, the most convincing usecase is with legacy GRE. > > Yes. But we still have a strong need for VXLAN and GENEVE to do symmetric > hashing. Please consider this. Using a specific key seems fragile though in that a different one is needed for e.g. ipv4 and ipv6. An issue with VXLAN and GENEVE, yes? Will support for XOR hashing address this sufficiently or is that not acceptable to you? Or alternatively a modified Toeplitz, e.g. this https://inbox.dpdk.org/dev/20190731123040.GG4512@6wind.com/ suggests Mellanox supports that. WDYT? -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/