Discussion of the VIRTIO specification
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <virtio-comment@lists.oasis-open.org>
Cc: <shahafs@nvidia.com>, <hengqi@linux.alibaba.com>,
	<virtio@lists.oasis-open.org>, Parav Pandit <parav@nvidia.com>
Subject: [virtio-comment] [PATCH requirements 4/7] net-features: Add notification coalescing requirements
Date: Mon, 24 Jul 2023 06:34:18 +0300	[thread overview]
Message-ID: <20230724033421.249893-5-parav@nvidia.com> (raw)
In-Reply-To: <20230724033421.249893-1-parav@nvidia.com>

Add virtio net device notification coalescing improvements requirements.

Signed-off-by: Parav Pandit <parav@nvidia.com>
---
changelog:
v1->v2:
- addressed comments from Stefan
- redrafted the requirements to use rearm term and avoid queue enable
  confusion
v0->v1:
- updated the description
---
 net-workstream/features-1.4.md | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/net-workstream/features-1.4.md b/net-workstream/features-1.4.md
index e04727a..27a7886 100644
--- a/net-workstream/features-1.4.md
+++ b/net-workstream/features-1.4.md
@@ -8,6 +8,7 @@ together is desired while updating the virtio net interface.
 # 2. Summary
 1. Device counters visible to the driver
 2. Low latency tx and rx virtqueues for PCI transport
+3. Virtqueue notification coalescing re-arming support
 
 # 3. Requirements
 ## 3.1 Device counters
@@ -164,3 +165,13 @@ struct vnet_rx_completion {
    which can be recycled by the driver when the packets from the completed
    page is fully consumed.
 8. The device should be able to consume multiple pages for a receive GSO stream.
+
+## 3.3 Virtqueue notification coalescing re-arming support
+0. Design goal:
+   a. Avoid constant notifications from the device even in conditions when
+      the driver may not have acted on the previous pending notification.
+1. When Tx and Rx virtqueue notification coalescing is enabled, and when such
+   a notification is reported by the device, the device stops sending further
+   notifications until the driver rearms the notifications of the virtqueue.
+2. When the driver rearms the notification of the virtqueue, the device
+   to notify again if notification coalescing conditions are met.
-- 
2.26.2


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  parent reply	other threads:[~2023-07-24  3:36 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24  3:34 [virtio-comment] [PATCH requirements 0/7] virtio net new features requirements Parav Pandit
2023-07-24  3:34 ` [virtio-comment] [PATCH requirements 1/7] net-features: Add requirements document for release 1.4 Parav Pandit
2023-08-08  8:16   ` David Edmondson
2023-08-14  5:17     ` Parav Pandit
2023-08-14 11:53       ` David Edmondson
2023-08-14 11:56   ` David Edmondson
2023-07-24  3:34 ` [virtio-comment] [PATCH requirements 2/7] net-features: Add low latency transmit queue requirements Parav Pandit
2023-08-08  8:24   ` David Edmondson
2023-08-10 19:05   ` [virtio-comment] RE: [EXT] [virtio] " Satananda Burla
2023-08-15  5:51     ` Parav Pandit
2023-08-14 11:55   ` [virtio-comment] " David Edmondson
2023-07-24  3:34 ` [virtio-comment] [PATCH requirements 3/7] net-features: Add low latency receive " Parav Pandit
2023-08-08  8:32   ` David Edmondson
2023-08-14 11:54   ` David Edmondson
2023-08-15  4:45     ` Parav Pandit
2023-07-24  3:34 ` Parav Pandit [this message]
2023-08-14 11:57   ` [virtio-comment] [PATCH requirements 4/7] net-features: Add notification coalescing requirements David Edmondson
2023-07-24  3:34 ` [virtio-comment] [PATCH requirements 5/7] net-features: Add n-tuple receive flow filters requirements Parav Pandit
2023-08-01  8:33   ` [virtio-comment] " Parav Pandit
2023-08-02  6:44     ` Parav Pandit
2023-08-02 15:32       ` Heng Qi
2023-08-03 10:01         ` Parav Pandit
2023-08-03 13:11           ` [virtio-comment] Re: [virtio] " Heng Qi
2023-08-02  7:17   ` [virtio-comment] RE: [EXT] [virtio] " Satananda Burla
2023-08-02  8:14     ` Parav Pandit
2023-08-02 18:32       ` Satananda Burla
2023-08-04  7:32         ` Parav Pandit
2023-08-02 15:25   ` [virtio-comment] " Heng Qi
2023-08-03  9:59     ` [virtio-comment] " Parav Pandit
2023-08-03 13:07       ` [virtio-comment] " Heng Qi
2023-08-04  6:20         ` [virtio-comment] " Parav Pandit
2023-08-04  7:17           ` [virtio-comment] " Heng Qi
2023-08-04  7:30             ` [virtio-comment] " Parav Pandit
2023-08-04  7:51               ` [virtio-comment] Re: [virtio] " Heng Qi
2023-08-07  7:22                 ` Heng Qi
2023-08-08  7:13                   ` Parav Pandit
2023-08-08  8:18                     ` [virtio-comment] Re: [virtio] " Heng Qi
2023-08-08  8:21       ` [virtio-comment] " Heng Qi
2023-08-14  5:15         ` [virtio-comment] " Parav Pandit
2023-08-14  6:18           ` [virtio-comment] " Heng Qi
2023-08-14  6:35             ` [virtio-comment] " Parav Pandit
2023-07-24  3:34 ` [virtio-comment] [PATCH requirements 6/7] net-features: Add packet timestamp requirements Parav Pandit
2023-08-09  8:35   ` [virtio-comment] Re: [virtio] " Xuan Zhuo
2023-08-10  6:56     ` Jason Wang
2023-08-15  6:13       ` Parav Pandit
     [not found]       ` <CAF=yD-+LMY3yE3qtd4vHc8CGOz6UAf4njM2QiZcajrQgL=KZRQ@mail.gmail.com>
2023-08-14  2:54         ` Jason Wang
2023-08-15  6:26         ` Parav Pandit
     [not found]           ` <CAF=yD-LXtrQeW0GnTR0BeDuExN5aBLC4dGEfdWbjtxmhNY2G6g@mail.gmail.com>
2023-08-16  4:10             ` Parav Pandit
2023-08-14 13:06     ` [virtio-comment] " Parav Pandit
2023-08-15  2:47       ` [virtio-comment] " Xuan Zhuo
2023-08-15  4:01         ` [virtio-comment] " Parav Pandit
2023-08-15  6:01           ` [virtio-comment] " Xuan Zhuo
2023-08-15  6:09             ` [virtio-comment] " Parav Pandit
2023-08-15  9:44               ` [virtio-comment] " Xuan Zhuo
2023-08-14 11:59   ` [virtio-comment] " David Edmondson
2023-07-24  3:34 ` [virtio-comment] [PATCH requirements 7/7] net-features: Add header data split requirements Parav Pandit
2023-08-10 19:19   ` [virtio-comment] RE: [EXT] [virtio] " Satananda Burla
2023-08-14 12:00   ` [virtio-comment] " David Edmondson
     [not found]     ` <CA+FuTSeguCKk4zxZ0=Ebr1phZhF9kssHeGPn2eZj6SRNv2ewsA@mail.gmail.com>
2023-08-14 13:09       ` [virtio-comment] Re: [virtio] " David Edmondson
2023-08-14 13:28         ` [virtio-comment] " Parav Pandit
2023-08-14 13:56           ` [virtio-comment] " David Edmondson
2023-08-15  4:41             ` [virtio-comment] " Parav Pandit
  -- strict thread matches above, loose matches on Subject: below --
2023-06-01 22:02 [virtio-comment] [PATCH requirements 0/7] virtio net new features requirements Parav Pandit
2023-06-01 22:03 ` [virtio-comment] [PATCH requirements 4/7] net-features: Add notification coalescing requirements Parav Pandit
2023-06-06 22:36   ` Michael S. Tsirkin
2023-06-06 22:46     ` Parav Pandit
2023-06-06 23:06       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230724033421.249893-5-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=hengqi@linux.alibaba.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox