Discussion of the VIRTIO specification
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <virtio-comment@lists.oasis-open.org>, <hengqi@linux.alibaba.com>,
	<david.edmondson@oracle.com>, <xuanzhuo@linux.alibaba.com>,
	<sburla@marvell.com>
Cc: <shahafs@nvidia.com>, <virtio@lists.oasis-open.org>,
	Parav Pandit <parav@nvidia.com>
Subject: [virtio-comment] [PATCH requirements v5 3/7] net-features: Add low latency receive queue requirements
Date: Fri, 18 Aug 2023 07:35:53 +0300	[thread overview]
Message-ID: <20230818043557.496964-4-parav@nvidia.com> (raw)
In-Reply-To: <20230818043557.496964-1-parav@nvidia.com>

Add requirements for the low latency receive queue.

Signed-off-by: Parav Pandit <parav@nvidia.com>
---
changelog:
v0->v1:
- clarified the requirements further
- added line for the gro case
- added design goals as the motivation for the requirements
---
 net-workstream/features-1.4.md | 45 +++++++++++++++++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)

diff --git a/net-workstream/features-1.4.md b/net-workstream/features-1.4.md
index 1167ce2..bc9e971 100644
--- a/net-workstream/features-1.4.md
+++ b/net-workstream/features-1.4.md
@@ -7,7 +7,7 @@ together is desired while updating the virtio net interface.
 
 # 2. Summary
 1. Device counters visible to the driver
-2. Low latency tx virtqueue for PCI transport
+2. Low latency tx and rx virtqueues for PCI transport
 
 # 3. Requirements
 ## 3.1 Device counters
@@ -127,3 +127,46 @@ struct vnet_data_desc desc[2];
 
 9. A flow filter virtqueue also similarly need the ability to inline the short flow
    command header.
+
+### 3.2.2 Low latency rx virtqueue
+0. Design goal:
+   a. Keep packet metadata and buffer data together which is consumed by driver
+      layer and make it available in a single cache line of cpu
+   b. Instead of having per packet descriptors which is complex to scale for
+      the device, supply the page directly to the device to consume it based
+      on packet size
+1. The device should be able to write a packet receive completion that consists
+   of struct virtio_net_hdr (or similar) and a buffer id using a single DMA write
+   PCIe TLP.
+2. The device should be able to perform DMA writes of multiple packets
+   completions in a single DMA transaction up to the PCIe maximum write limit
+   in a transaction.
+3. The device should be able to zero pad packet write completion to align it to
+   64B or CPU cache line size whenever possible.
+4. An example of the above DMA completion structure:
+
+```
+/* Constant size receive packet completion */
+struct vnet_rx_completion {
+   u16 flags;
+   u16 id; /* buffer id */
+   u8 gso_type;
+   u8 reserved[3];
+   le16 gso_hdr_len;
+   le16 gso_size;
+   le16 csum_start;
+   le16 csum_offset;
+   u16 reserved2;
+   u64 timestamp; /* explained later */
+   u8 padding[];
+};
+```
+5. The driver should be able to post constant-size buffer pages on a receive
+   queue which can be consumed by the device for an incoming packet of any size
+   from 64B to 9K bytes.
+6. The device should be able to know the constant buffer size at receive
+   virtqueue level instead of per buffer level.
+7. The device should be able to indicate when a full page buffer is consumed,
+   which can be recycled by the driver when the packets from the completed
+   page is fully consumed.
+8. The device should be able to consume multiple pages for a receive GSO stream.
-- 
2.26.2


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  parent reply	other threads:[~2023-08-18  4:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  4:35 [virtio-comment] [PATCH requirements v5 0/7] virtio net requirements for 1.4 Parav Pandit
2023-08-18  4:35 ` [virtio-comment] [PATCH requirements v5 1/7] net-features: Add requirements document for release 1.4 Parav Pandit
2023-08-21 10:44   ` David Edmondson
2023-08-18  4:35 ` [virtio-comment] [PATCH requirements v5 2/7] net-features: Add low latency transmit queue requirements Parav Pandit
2023-08-18  4:35 ` Parav Pandit [this message]
2023-08-21 10:47   ` [virtio-comment] Re: [PATCH requirements v5 3/7] net-features: Add low latency receive " David Edmondson
2023-08-22  6:12     ` [virtio-comment] " Parav Pandit
2023-09-11 13:47   ` [virtio-comment] Re: [virtio] " Stefan Hajnoczi
2023-09-11 16:03     ` [virtio-comment] " Parav Pandit
2023-08-18  4:35 ` [virtio-comment] [PATCH requirements v5 4/7] net-features: Add notification coalescing requirements Parav Pandit
2023-08-18  4:35 ` [virtio-comment] [PATCH requirements v5 5/7] net-features: Add n-tuple receive flow filters requirements Parav Pandit
2023-08-21  5:06   ` [virtio-comment] " Heng Qi
2023-08-21  5:14     ` [virtio-comment] " Parav Pandit
2023-08-22  7:41   ` Parav Pandit
2023-08-18  4:35 ` [virtio-comment] [PATCH requirements v5 6/7] net-features: Add packet timestamp requirements Parav Pandit
2023-08-18  4:35 ` [virtio-comment] [PATCH requirements v5 7/7] net-features: Add header data split requirements Parav Pandit
2023-08-21 10:45   ` [virtio-comment] " David Edmondson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230818043557.496964-4-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=david.edmondson@oracle.com \
    --cc=hengqi@linux.alibaba.com \
    --cc=sburla@marvell.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox