Re: [PATCH v5] virtio-net: clarify coalescing parameters settings

Cornelia Huck
2024-05-31T09:39:18Z

On Fri, May 31 2024, Heng Qi <hengqi@linux.alibaba.com> wrote:

> On Tue, 28 May 2024 12:50:34 +0800, Heng Qi <hengqi@linux.alibaba.com> wrote:
>> On Tue, 28 May 2024 12:47:02 +0800, Heng Qi <hengqi@linux.alibaba.com> wrote:
>> > The device can set any initial coalescing parameters (0 or non-zero)
>> > for the receive/send queue before the setting command is executed,
>> > not just 0, enhancing device performance even without DIM enabled.
>> >
>> > So we need to clarify descriptions that don't fit the behavior.
>> >
>> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/194
>> > Suggested-by: Jason Wang <jasowang@redhat.com>
>> > Signed-off-by: Heng Qi <hengqi@linux.alibaba.com>
>> > Reviewed-by: Parav Pandit <parav@nvidia.com>
>> > Reviewed-by: Jason Wang <jasowang@redhat.com>
>>
>> Hi, Cornelia!
>>
>> I'm wondering if our voting infrastructure is already working properly, and if
>> so, can we turn on voting for this update patch?

Oh, seems I forgot to send that mail out -- platform still has issues :(

>
> Do I need to repost a patch with the subject prefix [Request for vote]?

This one is already sitting on my list, no need to do so (and we haven't
actually finalized what it should look like, I'm still waiting for more
feedback before proposing a patch.)