Re: [GIT PULL virtio 00/40] virtio master branch with fixes and admin commands

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Jul 11, 2024 at 11:23:52PM +0300, Parav Pandit wrote:
> Hi Michael, Cornelia,
> 
> The following changes since commit 37c6a406678a5ee891fdf5671298cb4fcfa517f2:
> 
>   sound: add sampling rates 12000Hz and 24000Hz (2024-02-16 11:55:25 +0100)
> 
> are available in the Git repository at:
> 
>   https://github.com/paravmellanox/virtio-spec.git tags/for_1.4
> 
> for you to fetch changes up to 74bf759aef3bf10447aadcb841c66dc5e6a578d6:
> 
>   virtio_pci_cap64: specify offset_hi, length_hi endianness (2024-07-11 20:54:20 +0300)
> 
> ----------------------------------------------------------------
> This tag contains virtio master branch and set of patches of administration commands, pci fix, blk config fix, and net description fixes
> 
> - editorial changes froom master branch
> - virtio blk and pci capabilities data type fixes
> - virtio net header description update
> - adminstration commands for flow filters
> - administration commands for device parts
> 
> Generated PDF and also the diff pdf were verified using makepdf.sh, makediffall.sh and makediffpdf.sh.
> 
> ----------------------------------------------------------------
> Cornelia Huck (12):
>       edit: remove old changelog
>       edit: add changelog for 1.3
>       acknowledgements: update for 1.3
>       editorial: update copyright date in PDF footer to 2023
>       change revisions: diff from v1.2, current v1.3
>       title: note that 1.3 supercedes 1.2
>       revision: update date
>       remove enumerate usage that makes the tool unhappy
>       Revert "remove enumerate usage that makes the tool unhappy"
>       editorial: various fixes for 1.3-csd01
>       editorial: update "Computer Language Definitions" URL
>       makediff: update list of cherry-picks
> 
> Kröning (1):
>       virtio_pci_cap64: specify offset_hi, length_hi endianness
> 
> Michael S. Tsirkin (5):
>       changelog: tweak column width
>       changelog: formatting fixes
>       work around extra row
>       html: add missing enumitem package
>       README.md: update mailing list info
> 
> Parav Pandit (22):
>       virtio-blk: Fix data type of num_queues field
>       virtio-net: Fix receive buffer size calculation text
>       virtio-net: Clarify the size of the struct virtio_net_hdr for tx
>       virtio-net: Annotate virtio_net_hdr as field
>       admin: Introduce self group
>       admin: Use already defined names for the legacy commands
>       admin: Add theory of operation for capability admin commands
>       admin: Prepare table for multipage listing
>       admin: Add capability admin commands
>       admin: Add theory of operation for device resource objects
>       admin: Add device resource objects admin commands
>       virtio-net: Add theory of operation for flow filter
>       virtio-net: Add flow filter capability
>       virtio-net: Add flow filter group, classifier and rule resource objects
>       virtio-net: Add flow filter device and driver requirements
>       newdevice: Improve the appendix chapter heading to reflect the content
>       newdevice: Extend informative guidance on capability, resource objects
>       admin: Add theory of operation for device parts
>       admin: Extend resource objects for sr-iov group type
>       admin: Add admin commands for device parts
>       admin: Define common device parts
>       admin: Add requirements of device parts commands
> 
>  CONTRIBUTING.md                         |    2 +-
>  DIFFVERSION                             |    2 +-
>  README.md                               |   80 +-
>  REVISION                                |    2 +-
>  REVISION-DATE                           |    2 +-
>  acknowledgements.tex                    |  124 +-
>  admin-cmds-capabilities.tex             |  249 +++
>  admin-cmds-device-parts.tex             |  469 +++++
>  admin-cmds-legacy-interface.tex         |   24 +-
>  admin-cmds-resource-objects.tex         |  287 +++
>  admin.tex                               |   61 +-
>  changelog.tex                           |    6 +-
>  cl-cs02-12.tex                          | 2593 +++++++++++++++++++++++++++
>  cl-os.tex                               | 2897 +++++++++++++------------------
>  conformance.tex                         |    6 +
>  content.tex                             |    1 +
>  device-parts.tex                        |  231 +++
>  device-types/blk/description.tex        |    2 +-
>  device-types/net/description.tex        |  646 ++++++-
>  device-types/net/device-conformance.tex |    1 +
>  device-types/net/driver-conformance.tex |    1 +
>  introduction.tex                        |   32 +-
>  makediff.sh                             |    3 +-
>  newdevice.tex                           |   62 +-
>  specvars.tex                            |    2 +-
>  title.tex                               |   15 +-
>  transport-pci.tex                       |    4 +-
>  virtio-html.tex                         |    1 +
>  virtio.tex                              |    3 +
>  29 files changed, 6001 insertions(+), 1807 deletions(-)
>  create mode 100644 admin-cmds-capabilities.tex
>  create mode 100644 admin-cmds-device-parts.tex
>  create mode 100644 admin-cmds-resource-objects.tex
>  create mode 100644 cl-cs02-12.tex
>  create mode 100644 device-parts.tex

Thanks for working on this!
I made some changes to master, and I also merged master into 1.4.

I also see undefined references with this, related to device
parts things.  Which I guess means the original patch was broken.

So what I did is cherry-pick the rest of patches.
Update 1.4 you will see what happened.

As for device parts, you need to fix them up.
I do not remember if we discussed it, but I think you
are abusing hyperref for no reason there.

So my suggestion is, send a patch replacing all the
hyperref cuteness with simple ref and fixing broken links at the
same time.

OK?

-- 
MST