From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: virtio-comment@lists.linux.dev
Subject: Re: [PATCH 9/9] admin: get rid of _ in labels
Date: Tue, 16 Jul 2024 08:04:18 -0400 [thread overview]
Message-ID: <20240716080355-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87y161aix3.fsf@redhat.com>
On Tue, Jul 16, 2024 at 09:35:20AM +0200, Cornelia Huck wrote:
> On Mon, Jul 15 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > it's not the 1st time we find out underscores in labels confuse
> > latexdiff machinery when generating html.
> > Errors look like this:
> >
> > ! Missing \endcsname inserted.
> > <to be read again>
> > \unhbox
> > ....
> >
> > ?
> > ! Emergency stop.
> > <to be read again>
> > \unhbox
> >
> > To fix, convert underscores in labels to dashes.
> >
>
> Hm... should we add a "Avoid common pitfalls" section to the README?
> Anything else other than avoiding underscores in labels?
>
> (Not sure if that will help, things like that are easy to miss.)
Some kind of CI checking patches might help.
next prev parent reply other threads:[~2024-07-16 12:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 16:49 [PATCH 0/9] html fixes Michael S. Tsirkin
2024-07-15 16:49 ` [PATCH 1/9] makediff: look in subjects only Michael S. Tsirkin
2024-07-15 16:49 ` [PATCH 2/9] makediff: cherry pick table env change Michael S. Tsirkin
2024-07-15 16:49 ` [PATCH 3/9] admin: switch to tabularx Michael S. Tsirkin
2024-07-15 16:49 ` [PATCH 4/9] admin-cmds-device-parts: " Michael S. Tsirkin
2024-07-15 16:49 ` [PATCH 5/9] device-parts: " Michael S. Tsirkin
2024-07-15 16:49 ` [PATCH 6/9] admin-cmds-resource-objects: " Michael S. Tsirkin
2024-07-15 16:49 ` [PATCH 7/9] virtio: replace xltabular with ltablex Michael S. Tsirkin
2024-07-15 16:49 ` [PATCH 8/9] makediff: cherry pick switch to tabularx Michael S. Tsirkin
2024-07-15 16:50 ` [PATCH 9/9] admin: get rid of _ in labels Michael S. Tsirkin
2024-07-16 7:35 ` Cornelia Huck
2024-07-16 12:04 ` Michael S. Tsirkin [this message]
2024-07-29 5:04 ` [PATCH 0/9] html fixes Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240716080355-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox