* [PATCH] device-parts: editorial: Add missing struct keyword
@ 2024-07-29 9:20 Parav Pandit
2024-08-11 12:17 ` Parav Pandit
0 siblings, 1 reply; 4+ messages in thread
From: Parav Pandit @ 2024-07-29 9:20 UTC (permalink / raw)
To: virtio-comment, mst, cohuck; +Cc: shahafs, Parav Pandit
'struct' keyword was missing in the definition.
Add it.
Branch: virtio-1.4
Fixes: aa4f6f06 ("admin: Add admin commands for device parts")
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
admin-cmds-device-parts.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/admin-cmds-device-parts.tex b/admin-cmds-device-parts.tex
index 4c88045..27d8251 100644
--- a/admin-cmds-device-parts.tex
+++ b/admin-cmds-device-parts.tex
@@ -131,7 +131,7 @@ \subsubsection{Device parts}\label{sec:Basic Facilities of a Virtio Device / Dev
le32 count;
le32 reserved;
} hdr_list_count;
- {
+ struct {
le32 count;
le32 reserved;
struct virtio_dev_part_hdr hdrs[];
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] device-parts: editorial: Add missing struct keyword
2024-07-29 9:20 [PATCH] device-parts: editorial: Add missing struct keyword Parav Pandit
@ 2024-08-11 12:17 ` Parav Pandit
2024-08-17 5:20 ` Parav Pandit
0 siblings, 1 reply; 4+ messages in thread
From: Parav Pandit @ 2024-08-11 12:17 UTC (permalink / raw)
To: virtio-comment@lists.linux.dev, mst@redhat.com, cohuck@redhat.com
Cc: Shahaf Shuler
Hi Michael, Cornelia,
> -----Original Message-----
> From: Parav Pandit <parav@nvidia.com>
> Sent: Monday, July 29, 2024 2:50 PM
> To: virtio-comment@lists.linux.dev; mst@redhat.com; cohuck@redhat.com
> Cc: Shahaf Shuler <shahafs@nvidia.com>; Parav Pandit <parav@nvidia.com>
> Subject: [PATCH] device-parts: editorial: Add missing struct keyword
>
> 'struct' keyword was missing in the definition.
> Add it.
>
> Branch: virtio-1.4
> Fixes: aa4f6f06 ("admin: Add admin commands for device parts")
> Signed-off-by: Parav Pandit <parav@nvidia.com>
Can you please take this fix for the 1.4 branch?
> ---
> admin-cmds-device-parts.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/admin-cmds-device-parts.tex b/admin-cmds-device-parts.tex index
> 4c88045..27d8251 100644
> --- a/admin-cmds-device-parts.tex
> +++ b/admin-cmds-device-parts.tex
> @@ -131,7 +131,7 @@ \subsubsection{Device parts}\label{sec:Basic Facilities
> of a Virtio Device / Dev
> le32 count;
> le32 reserved;
> } hdr_list_count;
> - {
> + struct {
> le32 count;
> le32 reserved;
> struct virtio_dev_part_hdr hdrs[];
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] device-parts: editorial: Add missing struct keyword
2024-08-11 12:17 ` Parav Pandit
@ 2024-08-17 5:20 ` Parav Pandit
2024-09-05 4:09 ` Parav Pandit
0 siblings, 1 reply; 4+ messages in thread
From: Parav Pandit @ 2024-08-17 5:20 UTC (permalink / raw)
To: Parav Pandit, virtio-comment@lists.linux.dev, mst@redhat.com,
cohuck@redhat.com
Cc: Shahaf Shuler
Hi Michael,
> -----Original Message-----
> From: Parav Pandit <parav@nvidia.com>
> Sent: Sunday, August 11, 2024 5:48 PM
> To: virtio-comment@lists.linux.dev; mst@redhat.com; cohuck@redhat.com
> Cc: Shahaf Shuler <shahafs@nvidia.com>
> Subject: RE: [PATCH] device-parts: editorial: Add missing struct keyword
>
> Hi Michael, Cornelia,
>
> > -----Original Message-----
> > From: Parav Pandit <parav@nvidia.com>
> > Sent: Monday, July 29, 2024 2:50 PM
Can you please take this fix for 1.4 branch?
> > To: virtio-comment@lists.linux.dev; mst@redhat.com;
> cohuck@redhat.com
> > Cc: Shahaf Shuler <shahafs@nvidia.com>; Parav Pandit
> > <parav@nvidia.com>
> > Subject: [PATCH] device-parts: editorial: Add missing struct keyword
> >
> > 'struct' keyword was missing in the definition.
> > Add it.
> >
> > Branch: virtio-1.4
> > Fixes: aa4f6f06 ("admin: Add admin commands for device parts")
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
>
> Can you please take this fix for the 1.4 branch?
>
> > ---
> > admin-cmds-device-parts.tex | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/admin-cmds-device-parts.tex b/admin-cmds-device-parts.tex
> > index
> > 4c88045..27d8251 100644
> > --- a/admin-cmds-device-parts.tex
> > +++ b/admin-cmds-device-parts.tex
> > @@ -131,7 +131,7 @@ \subsubsection{Device parts}\label{sec:Basic
> > Facilities of a Virtio Device / Dev
> > le32 count;
> > le32 reserved;
> > } hdr_list_count;
> > - {
> > + struct {
> > le32 count;
> > le32 reserved;
> > struct virtio_dev_part_hdr hdrs[];
> > --
> > 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] device-parts: editorial: Add missing struct keyword
2024-08-17 5:20 ` Parav Pandit
@ 2024-09-05 4:09 ` Parav Pandit
0 siblings, 0 replies; 4+ messages in thread
From: Parav Pandit @ 2024-09-05 4:09 UTC (permalink / raw)
To: virtio-comment@lists.linux.dev, mst@redhat.com, cohuck@redhat.com
Cc: Shahaf Shuler
Hi Michael, Cornelia,
> From: Parav Pandit <parav@nvidia.com>
> Sent: Saturday, August 17, 2024 10:50 AM
>
> Hi Michael,
>
> > -----Original Message-----
> > From: Parav Pandit <parav@nvidia.com>
> > Sent: Sunday, August 11, 2024 5:48 PM
> > To: virtio-comment@lists.linux.dev; mst@redhat.com;
> cohuck@redhat.com
> > Cc: Shahaf Shuler <shahafs@nvidia.com>
> > Subject: RE: [PATCH] device-parts: editorial: Add missing struct
> > keyword
> >
> > Hi Michael, Cornelia,
> >
> > > -----Original Message-----
> > > From: Parav Pandit <parav@nvidia.com>
> > > Sent: Monday, July 29, 2024 2:50 PM
>
> Can you please take this fix for 1.4 branch?
>
Can you please take this fix for 1.4 branch?
This has been up for review for last 5+ weeks!
> > > To: virtio-comment@lists.linux.dev; mst@redhat.com;
> > cohuck@redhat.com
> > > Cc: Shahaf Shuler <shahafs@nvidia.com>; Parav Pandit
> > > <parav@nvidia.com>
> > > Subject: [PATCH] device-parts: editorial: Add missing struct keyword
> > >
> > > 'struct' keyword was missing in the definition.
> > > Add it.
> > >
> > > Branch: virtio-1.4
> > > Fixes: aa4f6f06 ("admin: Add admin commands for device parts")
> > > Signed-off-by: Parav Pandit <parav@nvidia.com>
> >
> > Can you please take this fix for the 1.4 branch?
> >
> > > ---
> > > admin-cmds-device-parts.tex | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/admin-cmds-device-parts.tex
> > > b/admin-cmds-device-parts.tex index
> > > 4c88045..27d8251 100644
> > > --- a/admin-cmds-device-parts.tex
> > > +++ b/admin-cmds-device-parts.tex
> > > @@ -131,7 +131,7 @@ \subsubsection{Device parts}\label{sec:Basic
> > > Facilities of a Virtio Device / Dev
> > > le32 count;
> > > le32 reserved;
> > > } hdr_list_count;
> > > - {
> > > + struct {
> > > le32 count;
> > > le32 reserved;
> > > struct virtio_dev_part_hdr hdrs[];
> > > --
> > > 2.34.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-05 4:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-29 9:20 [PATCH] device-parts: editorial: Add missing struct keyword Parav Pandit
2024-08-11 12:17 ` Parav Pandit
2024-08-17 5:20 ` Parav Pandit
2024-09-05 4:09 ` Parav Pandit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox