Re: [PATCH v1] virtio-crypto: add ECDSA op parameters

["Michael S. Tsirkin" <mst@redhat.com>]

I suggest you follow
https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues
to request a vote.



On Thu, Sep 05, 2024 at 12:16:44PM +0000, Gowrishankar Muthukrishnan wrote:
> Hi,
> Since it has been more than a month without a review, I would like to check if there is any information missing or any comments needed. Please help. Additionally, we need to capture this feature in the specifications to support SM2 and EDDSA in a similar way.
> 
> Also opened new ticket https://github.com/oasis-tcs/virtio-spec/issues/203 if it can help us.
> 
> Thanks,
> Gowrishankar
> 
> > 
> > >
> > > In ECDSA SIGN operation, a random scalar 'k' is used to generate one
> > > part of signature. As this value SHOULD be randomly secure, the
> > > application might supply it through secure RNG rather than relying on SIGN
> > implementation.
> > >
> > > Another parameter is prehash algorithm to hash source data before SIGN
> > > operation on it.
> > >
> > > Current data queue struct for AKCIPHER do not hold any option to input
> > > algorithm specific parameter. Hence, in this patch new fields are
> > > introduced in data queue struct for AKCIPHER to support additional
> > parameters.
> > >
> > > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> > 
> > Ping ?.
> > 
> > Regards,
> > Gowrishankar