[PATCH v1 0/5] Assorted editorial fixes

[PATCH v1 0/5] Assorted editorial fixes

[Parav Pandit]

This series covers assorted editorial fixes to fix name, adding missing struct 
and fix spelling errors.

changelog:
v0->v1:
- added Reviewed-by of Matias Ezequiel Vara Larsen
- added github issue link

Parav Pandit (5):
  device-parts: editorial: Add missing struct keyword
  device-parts: editorial: Fix metadata type name
  crypto: editorial: Fix spelling errors
  gpu: editorial: Fix spelling errors
  common: editorial: Fix spelling errors

 admin-cmds-device-parts.tex         |  6 +++---
 admin.tex                           |  2 +-
 content.tex                         |  4 ++--
 device-types/crypto/description.tex | 10 +++++-----
 device-types/gpu/description.tex    |  4 ++--
 5 files changed, 13 insertions(+), 13 deletions(-)

-- 
2.34.1

[PATCH v1 1/5] device-parts: editorial: Add missing struct keyword

[Parav Pandit]

'struct' keyword was missing in the definition.
Add it.

Branch: virtio-1.4
Fixes: aa4f6f06 ("admin: Add admin commands for device parts")
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 admin-cmds-device-parts.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/admin-cmds-device-parts.tex b/admin-cmds-device-parts.tex
index 4c88045..27d8251 100644
--- a/admin-cmds-device-parts.tex
+++ b/admin-cmds-device-parts.tex
@@ -131,7 +131,7 @@ \subsubsection{Device parts}\label{sec:Basic Facilities of a Virtio Device / Dev
                         le32 count;
                         le32 reserved;
                 } hdr_list_count;
-                {
+                struct {
                         le32 count;
                         le32 reserved;
                         struct virtio_dev_part_hdr hdrs[];
-- 
2.34.1

[PATCH v1 2/5] device-parts: editorial: Fix metadata type name

[Parav Pandit]

The description is for the type VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_TYPE_LIST;
however, it referred to a non-existent definition. Correct it.

Branch: virtio-1.4
Fixes: aa4f6f069ab3 ("admin: Add admin commands for device parts")
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/205
Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 admin-cmds-device-parts.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/admin-cmds-device-parts.tex b/admin-cmds-device-parts.tex
index 27d8251..3a16692 100644
--- a/admin-cmds-device-parts.tex
+++ b/admin-cmds-device-parts.tex
@@ -152,10 +152,10 @@ \subsubsection{Device parts}\label{sec:Basic Facilities of a Virtio Device / Dev
 device responds with \field{hdr_list_count.count}. The
 \field{hdr_list_count.count} indicates an count of
 \field{struct virtio_dev_part_hdr} metadata entries that the device can
-provide when the \field{type} is set to VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_TYPE_HDR
+provide when the \field{type} is set to VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_TYPE_LIST
 in a subsequent VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_GET command.
 
-When \field{type} is set to VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_TYPE_HDR,
+When \field{type} is set to VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_TYPE_LIST,
 the device responds with \field{hdr_list}. \field{hdr_list}
 indicates the device parts metadata.
 
-- 
2.34.1

[PATCH v1 3/5] crypto: editorial: Fix spelling errors

[Parav Pandit]

Fix spelling errors.

Branch: virtio-1.4
Fixes: a385dd3366a2 ("virtio-crypto: Add virtio crypto device specification")
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/205
Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 device-types/crypto/description.tex | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/device-types/crypto/description.tex b/device-types/crypto/description.tex
index 5705e26..e053cc7 100644
--- a/device-types/crypto/description.tex
+++ b/device-types/crypto/description.tex
@@ -424,11 +424,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Crypto Device / Devic
 
 \field{header} is a general header (see above).
 
-\field{op_flf} is the opcode (in \field{header}) specific fixed-length paramenters.
+\field{op_flf} is the opcode (in \field{header}) specific fixed-length parameters.
 
 \field{flf_len} depends on the VIRTIO_CRYPTO_F_REVISION_1 feature bit (see below).
 
-\field{op_vlf} is the opcode (in \field{header}) specific variable-length paramenters.
+\field{op_vlf} is the opcode (in \field{header}) specific variable-length parameters.
 
 \field{vlf_len} is the size of the specific structure used.
 \begin{note}
@@ -509,7 +509,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Crypto Device / Devic
 \subparagraph{Session operation: HASH session}\label{sec:Device Types / Crypto Device / Device
 Operation / Control Virtqueue / Session operation / Session operation: HASH session}
 
-The fixed-length paramenters of HASH session requests is as follows:
+The fixed-length parameters of HASH session requests is as follows:
 
 \begin{lstlisting}
 struct virtio_crypto_hash_create_session_flf {
@@ -1386,7 +1386,7 @@ \subsubsection{Symmetric algorithms Operation}\label{sec:Device Types / Crypto D
 \end{itemize*}
 
 The length of \field{op_type_flf} is fixed to 40 bytes, the data of unused
-part (if has) will be ingored.
+part (if has) will be ignored.
 
 \field{op_type_vlf} is the \field{op_type} specific parameters, it MUST starts
 with or be one of the following structures:
@@ -1536,7 +1536,7 @@ \subsubsection{Symmetric algorithms Operation}\label{sec:Device Types / Crypto D
 \end{itemize*}
 
 The length of \field{op_type_flf} is fixed to 72 bytes, the data of unused
-part (if has) will be ingored.
+part (if has) will be ignored.
 
 \field{op_type_vlf} is the \field{op_type} specific parameters, it MUST starts
 with or be one of the following structures:
-- 
2.34.1

[PATCH v1 4/5] gpu: editorial: Fix spelling errors

[Parav Pandit]

Fix spelling errors.

Branch: virtio-1.4
Fixes: fed64230bf31 ("Add virtio gpu device specification.")
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/205
Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 device-types/gpu/description.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/device-types/gpu/description.tex b/device-types/gpu/description.tex
index 66e4873..ba4ea76 100644
--- a/device-types/gpu/description.tex
+++ b/device-types/gpu/description.tex
@@ -166,7 +166,7 @@ \subsubsection{Device Operation: Multihead setup}
 
 \devicenormative{\subsubsection}{Device Operation: Command lifecycle and fencing}{Device Types / GPU Device / Device Operation / Device Operation: Command lifecycle and fencing}
 
-The device MAY process controlq commands asyncronously and return them
+The device MAY process controlq commands asynchronously and return them
 to the driver before the processing is complete.  If the driver needs
 to know when the processing is finished it can set the
 VIRTIO_GPU_FLAG_FENCE flag in the request.  The device MUST finish the
@@ -345,7 +345,7 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 display).
 
 The \field{enabled} field is set when the user enabled the display.
-It is roughly the same as the connected state of a phyiscal display
+It is roughly the same as the connected state of a physical display
 connector.
 
 \item[VIRTIO_GPU_CMD_GET_EDID] Retrieve the EDID data for a given
-- 
2.34.1

[PATCH v1 5/5] common: editorial: Fix spelling errors

[Parav Pandit]

Fix spelling errors.

Branch: virtio-1.4
Fixes: 5f1a8ac61c15 ("admin: introduce virtio admin virtqueues")
Fixes: 68f66ff7a3d9 ("content: define what an exported object is")
Fixes: ef16b644cc25 ("content.tex: spec text converted to latex")
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/205
Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 admin.tex   | 2 +-
 content.tex | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/admin.tex b/admin.tex
index 95054ed..845ca02 100644
--- a/admin.tex
+++ b/admin.tex
@@ -496,7 +496,7 @@ \section{Administration Virtqueues}\label{sec:Basic Facilities of a Virtio Devic
 than one administration virtqueue.
 
 If VIRTIO_F_ADMIN_VQ has been negotiated, an owner device exposes one
-or more adminstration virtqueues. The number and locations of the
+or more administration virtqueues. The number and locations of the
 administration virtqueues are exposed by the owner device in a transport
 specific manner.
 
diff --git a/content.tex b/content.tex
index 12f9224..c5e7d5a 100644
--- a/content.tex
+++ b/content.tex
@@ -493,7 +493,7 @@ \section{Driver Notifications} \label{sec:Basic Facilities of a Virtio Device /
 \section{Exporting Objects}\label{sec:Basic Facilities of a Virtio Device / Exporting Objects}
 
 When an object created by one virtio device needs to be
-shared with a seperate virtio device, the first device can
+shared with a separate virtio device, the first device can
 export the object by generating a UUID which can then
 be passed to the second device to identify the object.
 
@@ -508,7 +508,7 @@ \section{Exporting Objects}\label{sec:Basic Facilities of a Virtio Device / Expo
 \chapter{General Initialization And Device Operation}\label{sec:General Initialization And Device Operation}
 
 We start with an overview of device initialization, then expand on the
-details of the device and how each step is preformed.  This section
+details of the device and how each step is performed.  This section
 is best read along with the bus-specific section which describes
 how to communicate with the specific device.
 
-- 
2.34.1

RE: [PATCH v1 0/5] Assorted editorial fixes

[Parav Pandit]

Hi Michael, Cornelia,

> From: Parav Pandit <parav@nvidia.com>
> Sent: Monday, September 16, 2024 8:39 AM
> To: virtio-comment@lists.linux.dev; mst@redhat.com; cohuck@redhat.com
> Cc: Shahaf Shuler <shahafs@nvidia.com>; Parav Pandit <parav@nvidia.com>
> Subject: [PATCH v1 0/5] Assorted editorial fixes
> 
> This series covers assorted editorial fixes to fix name, adding missing struct
> and fix spelling errors.
> 
> changelog:
> v0->v1:
> - added Reviewed-by of Matias Ezequiel Vara Larsen
> - added github issue link
>

Please open a voting ballot for these fixes.
The github link is: https://lore.kernel.org/virtio-comment/20240916030835.68178-1-parav@nvidia.com/T/#t


 
> Parav Pandit (5):
>   device-parts: editorial: Add missing struct keyword
>   device-parts: editorial: Fix metadata type name
>   crypto: editorial: Fix spelling errors
>   gpu: editorial: Fix spelling errors
>   common: editorial: Fix spelling errors
> 
>  admin-cmds-device-parts.tex         |  6 +++---
>  admin.tex                           |  2 +-
>  content.tex                         |  4 ++--
>  device-types/crypto/description.tex | 10 +++++-----
>  device-types/gpu/description.tex    |  4 ++--
>  5 files changed, 13 insertions(+), 13 deletions(-)
> 
> --
> 2.34.1

Re: [PATCH v1 0/5] Assorted editorial fixes

[Michael S. Tsirkin]

On Mon, Sep 16, 2024 at 03:11:10AM +0000, Parav Pandit wrote:
> Hi Michael, Cornelia,
> 
> > From: Parav Pandit <parav@nvidia.com>
> > Sent: Monday, September 16, 2024 8:39 AM
> > To: virtio-comment@lists.linux.dev; mst@redhat.com; cohuck@redhat.com
> > Cc: Shahaf Shuler <shahafs@nvidia.com>; Parav Pandit <parav@nvidia.com>
> > Subject: [PATCH v1 0/5] Assorted editorial fixes
> > 
> > This series covers assorted editorial fixes to fix name, adding missing struct
> > and fix spelling errors.
> > 
> > changelog:
> > v0->v1:
> > - added Reviewed-by of Matias Ezequiel Vara Larsen
> > - added github issue link
> >
> 
> Please open a voting ballot for these fixes.
> The github link is: https://lore.kernel.org/virtio-comment/20240916030835.68178-1-parav@nvidia.com/T/#t

yes but everyone is at plumbers/kvm forum.
Pls request it in a week's time, ok?

> 
>  
> > Parav Pandit (5):
> >   device-parts: editorial: Add missing struct keyword
> >   device-parts: editorial: Fix metadata type name
> >   crypto: editorial: Fix spelling errors
> >   gpu: editorial: Fix spelling errors
> >   common: editorial: Fix spelling errors
> > 
> >  admin-cmds-device-parts.tex         |  6 +++---
> >  admin.tex                           |  2 +-
> >  content.tex                         |  4 ++--
> >  device-types/crypto/description.tex | 10 +++++-----
> >  device-types/gpu/description.tex    |  4 ++--
> >  5 files changed, 13 insertions(+), 13 deletions(-)
> > 
> > --
> > 2.34.1

RE: [PATCH v1 0/5] Assorted editorial fixes

[Parav Pandit]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Monday, September 16, 2024 2:05 PM
> 
> On Mon, Sep 16, 2024 at 03:11:10AM +0000, Parav Pandit wrote:
> > Hi Michael, Cornelia,
> >
> > > From: Parav Pandit <parav@nvidia.com>
> > > Sent: Monday, September 16, 2024 8:39 AM
> > > To: virtio-comment@lists.linux.dev; mst@redhat.com;
> > > cohuck@redhat.com
> > > Cc: Shahaf Shuler <shahafs@nvidia.com>; Parav Pandit
> > > <parav@nvidia.com>
> > > Subject: [PATCH v1 0/5] Assorted editorial fixes
> > >
> > > This series covers assorted editorial fixes to fix name, adding
> > > missing struct and fix spelling errors.
> > >
> > > changelog:
> > > v0->v1:
> > > - added Reviewed-by of Matias Ezequiel Vara Larsen
> > > - added github issue link
> > >
> >
> > Please open a voting ballot for these fixes.
> > The github link is:
> > https://lore.kernel.org/virtio-comment/20240916030835.68178-1-
> parav@nv
> > idia.com/T/#t
> 
> yes but everyone is at plumbers/kvm forum.
> Pls request it in a week's time, ok?
Ok. thanks.

> 
> >
> >
> > > Parav Pandit (5):
> > >   device-parts: editorial: Add missing struct keyword
> > >   device-parts: editorial: Fix metadata type name
> > >   crypto: editorial: Fix spelling errors
> > >   gpu: editorial: Fix spelling errors
> > >   common: editorial: Fix spelling errors
> > >
> > >  admin-cmds-device-parts.tex         |  6 +++---
> > >  admin.tex                           |  2 +-
> > >  content.tex                         |  4 ++--
> > >  device-types/crypto/description.tex | 10 +++++-----
> > >  device-types/gpu/description.tex    |  4 ++--
> > >  5 files changed, 13 insertions(+), 13 deletions(-)
> > >
> > > --
> > > 2.34.1

RE: [PATCH v1 0/5] Assorted editorial fixes

[Parav Pandit]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Monday, September 16, 2024 2:05 PM
> 
> On Mon, Sep 16, 2024 at 03:11:10AM +0000, Parav Pandit wrote:
> > Hi Michael, Cornelia,
> >
> > > From: Parav Pandit <parav@nvidia.com>
> > > Sent: Monday, September 16, 2024 8:39 AM
> > > To: virtio-comment@lists.linux.dev; mst@redhat.com;
> > > cohuck@redhat.com
> > > Cc: Shahaf Shuler <shahafs@nvidia.com>; Parav Pandit
> > > <parav@nvidia.com>
> > > Subject: [PATCH v1 0/5] Assorted editorial fixes
> > >
> > > This series covers assorted editorial fixes to fix name, adding
> > > missing struct and fix spelling errors.
> > >
> > > changelog:
> > > v0->v1:
> > > - added Reviewed-by of Matias Ezequiel Vara Larsen
> > > - added github issue link
> > >
> >
> > Please open a voting ballot for these fixes.
> > The github link is:
> > https://lore.kernel.org/virtio-comment/20240916030835.68178-1-
> parav@nv
> > idia.com/T/#t
> 
> yes but everyone is at plumbers/kvm forum.
> Pls request it in a week's time, ok?

Can you please open the ballot now?

> 
> >
> >
> > > Parav Pandit (5):
> > >   device-parts: editorial: Add missing struct keyword
> > >   device-parts: editorial: Fix metadata type name
> > >   crypto: editorial: Fix spelling errors
> > >   gpu: editorial: Fix spelling errors
> > >   common: editorial: Fix spelling errors
> > >
> > >  admin-cmds-device-parts.tex         |  6 +++---
> > >  admin.tex                           |  2 +-
> > >  content.tex                         |  4 ++--
> > >  device-types/crypto/description.tex | 10 +++++-----
> > >  device-types/gpu/description.tex    |  4 ++--
> > >  5 files changed, 13 insertions(+), 13 deletions(-)
> > >
> > > --
> > > 2.34.1