Re: [PATCH 2/3] device-parts: Add device type specific raw selector

Matias Ezequiel Vara Larsen
2024-10-18T16:13:15Z

On Fri, Oct 18, 2024 at 04:17:40PM +0300, Parav Pandit wrote:
> The subsequent patch defines the device-type-specific parts. For
> these parts, the raw selector format is defined to ensure that
> each device type can specify its format accurately.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/209
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> device-parts.tex | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/device-parts.tex b/device-parts.tex
> index e59c0f9..ee743c2 100644
> --- a/device-parts.tex
> +++ b/device-parts.tex
> @@ -21,6 +21,7 @@ \section{Device parts}\label{sec:Basic Facilities of a Virtio Device / Device pa
> le16 index;
> u8 reserved[6];
> } vq_index;
> + u8 device_type_raw[8];
> } selector;
> le32 length;
> };
> @@ -77,6 +78,9 @@ \section{Device parts}\label{sec:Basic Facilities of a Virtio Device / Device pa
> only when the \field{part_type} is VIRTIO_DEV_PART_VQ_CFG or
> VIRTIO_DEV_PART_VQ_NOTIFY_CFG.
>
> +\field{selector.device_type_raw} is only used when a device-specific part is
> +utilized, with \field{part_type} ranging from 0x0200 to 0x05FF.

Why is important here to mention the range of `part_type`?

Matias