public inbox for virtio-comment@lists.linux.dev
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <virtio-comment@lists.linux.dev>, <mst@redhat.com>,
	<cohuck@redhat.com>, <mvaralar@redhat.com>
Cc: <shahafs@nvidia.com>, Parav Pandit <parav@nvidia.com>
Subject: [PATCH v1 2/3] device-parts: Add device type specific raw selector
Date: Sun, 20 Oct 2024 14:41:40 +0300	[thread overview]
Message-ID: <20241020114141.451478-3-parav@nvidia.com> (raw)
In-Reply-To: <20241020114141.451478-1-parav@nvidia.com>

The subsequent patch defines the device-type-specific parts. For
these parts, the raw selector format is defined to ensure that
each device type can specify its format accurately.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/209
Signed-off-by: Parav Pandit <parav@nvidia.com>

---
changelog:
v0->v1:
- addressed comment from Matias
- rewrote description of selector without writing the actual
  part_type range, add description that it is device type specific
---
 device-parts.tex | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/device-parts.tex b/device-parts.tex
index e59c0f9..1d6be87 100644
--- a/device-parts.tex
+++ b/device-parts.tex
@@ -21,6 +21,7 @@ \section{Device parts}\label{sec:Basic Facilities of a Virtio Device / Device pa
                         le16 index;
                         u8 reserved[6];
                 } vq_index;
+		u8 device_type_raw[8];
         } selector;
         le32 length;
 };
@@ -77,6 +78,10 @@ \section{Device parts}\label{sec:Basic Facilities of a Virtio Device / Device pa
 only when the \field{part_type} is VIRTIO_DEV_PART_VQ_CFG or
 VIRTIO_DEV_PART_VQ_NOTIFY_CFG.
 
+\field{selector.device_type_raw} is applicable only when the \field{part_type}
+corresponds to a device-specific range. The format of
+\field{selector.device_type_raw} is device type specific.
+
 \subsection{Common device parts}\label{sec:Basic Facilities of a Virtio Device / Device parts / Common device parts}
 
 Common parts are independent of the device type.
-- 
2.34.1


  parent reply	other threads:[~2024-10-20 11:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-20 11:41 [PATCH v1 0/3] virtio-net: Define cvq configuration related device parts Parav Pandit
2024-10-20 11:41 ` [PATCH v1 1/3] device-parts: editorial: Replace duplicated part type Parav Pandit
2024-10-20 11:41 ` Parav Pandit [this message]
2024-10-21 18:12   ` [PATCH v1 2/3] device-parts: Add device type specific raw selector Matias Ezequiel Vara Larsen
2024-10-20 11:41 ` [PATCH v1 3/3] virtio-net: Define cvq configuration related device parts Parav Pandit
2024-11-03  5:15 ` [PATCH v1 0/3] " Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241020114141.451478-3-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=mvaralar@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox