public inbox for virtio-comment@lists.linux.dev
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <virtio-comment@lists.linux.dev>, <mst@redhat.com>,
	<cohuck@redhat.com>, <mvaralar@redhat.com>
Cc: <shahafs@nvidia.com>, Parav Pandit <parav@nvidia.com>
Subject: [PATCH v1] virtio-net: Fix to avoid using reserved feature bits
Date: Sun, 26 Jan 2025 08:20:58 +0200	[thread overview]
Message-ID: <20250126062058.13695-1-parav@nvidia.com> (raw)

Listed patches in the fixes tag, incorrectly used the reserved feature bits.
Fix them to use the well defined device specific range.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/212
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/213
Fixes: 8cd457d8aa82 ("virtio-net: define UDP tunnel segmentation offload feature")
Fixes: 3fea589bd7c6 ("virtio-net: define UDP tunnel checksum offload feature")
Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>

---
changelog:
v0->v1:
- added Cornelia's reviewed-by
- added github issue number
- skipped Paolo's suggestion to modify 'le64 offloads' as its only 64-bits
  and new feature bits are in > 64 bits range
---
 device-types/net/description.tex | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index efb543f..b546cd7 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -88,18 +88,6 @@ \subsection{Feature bits}\label{sec:Device Types / Network Device / Feature bits
 \item[VIRTIO_NET_F_CTRL_MAC_ADDR(23)] Set MAC address through control
     channel.
 
-\item[VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO (46)] Driver can receive GSO packets
-  carried by a UDP tunnel.
-
-\item[VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM (47)] Driver handles packets
-  carried by a UDP tunnel with partial csum for the outer header.
-
-\item[VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO (48)] Device can receive GSO packets
-  carried by a UDP tunnel.
-
-\item[VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO_CSUM (49)] Device handles packets
-  carried by a UDP tunnel with partial csum for the outer header.
-
 \item[VIRTIO_NET_F_DEVICE_STATS(50)] Device can provide device-level statistics
     to the driver through the control virtqueue.
 
@@ -136,6 +124,18 @@ \subsection{Feature bits}\label{sec:Device Types / Network Device / Feature bits
 \item[VIRTIO_NET_F_SPEED_DUPLEX(63)] Device reports speed and duplex.
 
 \item[VIRTIO_NET_F_RSS_CONTEXT(64)] Device supports multiple RSS contexts.
+
+\item[VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO (65)] Driver can receive GSO packets
+  carried by a UDP tunnel.
+
+\item[VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM (66)] Driver handles packets
+  carried by a UDP tunnel with partial csum for the outer header.
+
+\item[VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO (67)] Device can receive GSO packets
+  carried by a UDP tunnel.
+
+\item[VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO_CSUM (68)] Device handles packets
+  carried by a UDP tunnel with partial csum for the outer header.
 \end{description}
 
 \subsubsection{Feature bit requirements}\label{sec:Device Types / Network Device / Feature bits / Feature bit requirements}
-- 
2.34.1


             reply	other threads:[~2025-01-26  6:21 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-26  6:20 Parav Pandit [this message]
2025-01-26  9:19 ` [PATCH v1] virtio-net: Fix to avoid using reserved feature bits Michael S. Tsirkin
2025-01-26 16:44   ` Parav Pandit
2025-01-26 16:50     ` Michael S. Tsirkin
2025-01-27  9:21       ` Cornelia Huck
2025-01-27 12:54         ` Parav Pandit
2025-04-22 17:49 ` Paolo Abeni
2025-04-23  5:46   ` Michael S. Tsirkin
2025-04-23 16:05     ` Paolo Abeni
2025-04-28  9:13       ` Michael S. Tsirkin
2025-04-28 17:07         ` Paolo Abeni
2025-04-28 17:18           ` Michael S. Tsirkin
2025-04-23 16:29     ` Daniel Verkamp
2025-04-23 18:07       ` Michael S. Tsirkin
2025-04-28  8:39         ` Paolo Abeni
2025-04-28  8:47           ` Michael S. Tsirkin
2025-04-29 20:43           ` Michael S. Tsirkin
2025-04-30  4:44             ` Parav Pandit
2025-04-30  5:25               ` Yuri Benditovich
2025-04-30  5:44                 ` Parav Pandit
2025-04-30 10:12               ` Paolo Abeni
2025-04-30 10:54                 ` Parav Pandit
2025-05-01 13:42                   ` Michael S. Tsirkin
2025-05-01 15:57                     ` Paolo Abeni
2025-05-06  6:15                     ` Parav Pandit
2025-05-06  7:56                       ` Michael S. Tsirkin
2025-05-06  8:56                         ` Parav Pandit
2025-05-06 14:38                           ` Paolo Abeni
2025-05-06 15:00                             ` Parav Pandit
2025-05-06 15:40                               ` Paolo Abeni
2025-05-06 16:20                                 ` Parav Pandit
2025-05-07  9:57                                   ` Paolo Abeni
2025-05-08  6:15                                     ` Michael S. Tsirkin
2025-05-19  8:57                                     ` Paolo Abeni
2025-05-19  9:04                                       ` Parav Pandit
2025-05-19  9:24                                         ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250126062058.13695-1-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=mvaralar@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox