public inbox for virtio-comment@lists.linux.dev
 help / color / mirror / Atom feed
From: Sergio Lopez <slp@redhat.com>
To: virtio-comment@lists.linux.dev
Cc: Sergio Lopez <slp@redhat.com>
Subject: [PATCH 0/3] shared-mem: introduce page alignment restrictions
Date: Mon, 17 Feb 2025 12:52:24 +0100	[thread overview]
Message-ID: <20250217115227.4961-1-slp@redhat.com> (raw)

There's an incresing number of machines supporting multiple page sizes
and, on these machines, the host and a guest can be running with
different pages sizes.

In addition to this, there might be devices that have a required and/or
preferred page size for mapping memory.

In this series we extend the "Shared Memory Regions" with a subsection
explaining the posible existence of page alignment restrictions.

For the device to provide the page size information to the driver, we
need to extend the PCI and MMIO transports. For the former, we borrow
8 bits from the 16 bit padding in virtio_pci_cap to hold a page_shift
field which can be used to derive the page size by using the following
formula: (page_size = 1 << (page_shift + 12)).

For MMIO, we add a the SHMPageShift register at offset 0x0c4, also
holding the page_shift value. Since MMIO registers are 32 bit wide, we
could have asked the device to directly provide page_size instead of
page_shift, but seems reasonable to be consistent across transports.

Since accessing a new MMIO register could be interpreted by the device
as an error, this behavior is gated behind the newly introduced
VIRTIO_F_SHM_PAGE_SIZE feature bit.

An implementation of the changes proposed in this series has been
published as an RFC to the LKML, to be used as a reference:

https://lore.kernel.org/all/20250214-virtio-shm-page-size-v2-0-aa1619e6908b@redhat.com/

Sergio Lopez (3):
  shared-mem: introduce page alignment restrictions
  transport-pci: VIRTIO_F_SHM_PAGE_SIZE support
  transport-mmio: VIRTIO_F_SHM_PAGE_SIZE

 content.tex        |  3 +++
 shared-mem.tex     |  7 +++++++
 transport-mmio.tex |  8 ++++++++
 transport-pci.tex  | 10 +++++++++-
 4 files changed, 27 insertions(+), 1 deletion(-)

-- 
2.48.1


             reply	other threads:[~2025-02-17 11:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 11:52 Sergio Lopez [this message]
2025-02-17 11:52 ` [PATCH 1/3] shared-mem: introduce page alignment restrictions Sergio Lopez
2025-02-23  5:21   ` Parav Pandit
2025-02-26 17:49     ` Sergio Lopez Pascual
2025-03-05 11:18       ` Parav Pandit
2025-03-05 19:08         ` Sergio Lopez Pascual
2025-03-06  3:09           ` Parav Pandit
2025-03-04 10:40     ` Michael S. Tsirkin
2025-03-04 10:52     ` Michael S. Tsirkin
2025-03-04 10:58       ` Parav Pandit
2025-03-04 12:50         ` Michael S. Tsirkin
2025-02-17 11:52 ` [PATCH 2/3] transport-pci: VIRTIO_F_SHM_PAGE_SIZE support Sergio Lopez
2025-02-17 11:52 ` [PATCH 3/3] transport-mmio: VIRTIO_F_SHM_PAGE_SIZE Sergio Lopez
2025-02-20  2:15 ` [PATCH 0/3] shared-mem: introduce page alignment restrictions Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250217115227.4961-1-slp@redhat.com \
    --to=slp@redhat.com \
    --cc=virtio-comment@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox