From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Zhang, Julia" <Julia.Zhang@amd.com>
Cc: "virtio-comment@lists.linux.dev" <virtio-comment@lists.linux.dev>,
"Chen, Jiqian" <Jiqian.Chen@amd.com>,
"Zhu, Lingshan" <Lingshan.Zhu@amd.com>,
Matias Ezequiel Vara Larsen <mvaralar@redhat.com>,
"Huang, Ray" <Ray.Huang@amd.com>
Subject: Re: [PATCH] virtio-gpu: get p2pdma distance
Date: Wed, 26 Feb 2025 02:17:00 -0500 [thread overview]
Message-ID: <20250226021617-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <IA1PR12MB6532FC13BDCAF1D2E0D336E0F2C22@IA1PR12MB6532.namprd12.prod.outlook.com>
On Wed, Feb 26, 2025 at 02:26:32AM +0000, Zhang, Julia wrote:
> Hi MST,
>
> On 2025/1/21 22:00, Matias Ezequiel Vara Larsen wrote:
> > On Tue, Jan 14, 2025 at 06:16:13PM +0800, Julia Zhang wrote:
> >> PCI peer-to-peer DMA transaction may be used in guest for some scenes.
> >> For example, dGPU prime feature will let virtio-iGPU access to
> >> passthrough dGPU buffer.
> >>
> >> To support P2P DMA transaction in guest, virtio-gpu needs to check the
> >> compatibility which is represented by p2pdma_distance. This defines a
> >> command VIRTIO_GPU_CMD_P2PDMA_DISTANCE to allow guest send virtual pci
> >> notation of two devices to host and get host physical p2pdma_distance
> >> of these two PCI devices.
> >>
> >> Signed-off-by: Julia Zhang <julia.zhang@amd.com>
> >> ---
> >> Hi all,
> >>
> >> We are trying to implement dGPU prime feature in guest which will let
> >> virtio-iGPU read rendered data of passthrough dGPU. Before that,
> >> virtio gpu driver needs to get p2pdma_distance to check if P2P DMA
> >> transaction is possible or not.
> >>
> >> To implement getting p2pdma_distance, QEMU needs to handle the command
> >> from guest with virtual pci notations of two PCI devices and send it to
> >> host kernel and return host physical distance back to guest.
> >>
> >> So this defines the new command follow the suggestion in
> >> https://lore.kernel.org/all/20241207105537.542441-4-julia.zhang@amd.com/
> >>
> >> Regards,
> >> Julia
> >> ---
> >> device-types/gpu/description.tex | 29 +++++++++++++++++++++++++++++
> >> 1 file changed, 29 insertions(+)
> >>
> >
> > Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> >
> Does this patch meet all requirements for merging? If not, what should I
> do next step? Should I create a MR on github?
>
> Regards,
> Julia
No, here are the instructions:
https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues
prev parent reply other threads:[~2025-02-26 7:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 10:16 [PATCH] virtio-gpu: get p2pdma distance Julia Zhang
2025-01-21 14:00 ` Matias Ezequiel Vara Larsen
2025-02-26 2:26 ` Zhang, Julia
2025-02-26 7:17 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226021617-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Jiqian.Chen@amd.com \
--cc=Julia.Zhang@amd.com \
--cc=Lingshan.Zhu@amd.com \
--cc=Ray.Huang@amd.com \
--cc=mvaralar@redhat.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox