[PATCH v3 0/3] VirtIO-GPU spec improvements

[PATCH v3 0/3] VirtIO-GPU spec improvements

[Dmitry Osipenko]

Hi,

This is a repost of v2 to the new virtio-comment mailing list.
Michael Tsirkin suggested to repost the patches, here they are.

Dmitry Osipenko (3):
  virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN
  virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM
  virtio-gpu: Update venus-protocol URL

 device-types/gpu/description.tex | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

-- 
2.45.2

[PATCH v3 1/3] virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN

[Dmitry Osipenko]

Initially, the plan was to use a single GFXSTREAM context for all of
GLES/GL/VK gfxstream sub-contexts. Over time the plan changed and
GFXSTREAM context became used exclusively for Vulkan, while GLES/GL
contexts were moved to a new own experimental virtio-gpu contexts.
Rename GFXSTREAM capset to GFXSTREAM_VULKAN.

Acked-by: Huang Rui <ray.huang@amd.com>
Link: https://lore.kernel.org/dri-devel/CAAfnVB=Mki1zEyjByJ_7tRrib74E4KSbjezqQcb_Uia8EQEXHw@mail.gmail.com/
Link: https://chromium.googlesource.com/chromiumos/platform/crosvm/+/e4c1878733937042111fca58899a3a94002bfef0
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 device-types/gpu/description.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/device-types/gpu/description.tex b/device-types/gpu/description.tex
index 443524851a05..4b8dd7733c31 100644
--- a/device-types/gpu/description.tex
+++ b/device-types/gpu/description.tex
@@ -530,8 +530,8 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 	the first edition of Virgl (Gallium OpenGL) protocol.
   \item \href{https://gitlab.freedesktop.org/virgl/virglrenderer/-/blob/master/src/virgl_hw.h#L550}{VIRTIO_GPU_CAPSET_VIRGL2} --
 	the second edition of Virgl (Gallium OpenGL) protocol after the capset fix.
-  \item \href{https://android.googlesource.com/device/generic/vulkan-cereal/+/refs/heads/master/protocols/}{VIRTIO_GPU_CAPSET_GFXSTREAM} --
-	gfxtream's (mostly) autogenerated GLES and Vulkan streaming protocols.
+  \item \href{https://android.googlesource.com/device/generic/vulkan-cereal/+/refs/heads/android13-release/protocols/vulkan/}{VIRTIO_GPU_CAPSET_GFXSTREAM_VULKAN} --
+	gfxtream's (mostly) autogenerated Vulkan streaming protocol.
   \item \href{https://gitlab.freedesktop.org/olv/venus-protocol}{VIRTIO_GPU_CAPSET_VENUS} --
 	Mesa's (mostly) autogenerated Vulkan protocol.
   \item \href{https://chromium.googlesource.com/chromiumos/platform/crosvm/+/refs/heads/main/rutabaga_gfx/src/cross_domain/cross_domain_protocol.rs}{VIRTIO_GPU_CAPSET_CROSS_DOMAIN} --
@@ -547,7 +547,7 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 
 #define VIRTIO_GPU_CAPSET_VIRGL 1
 #define VIRTIO_GPU_CAPSET_VIRGL2 2
-#define VIRTIO_GPU_CAPSET_GFXSTREAM 3
+#define VIRTIO_GPU_CAPSET_GFXSTREAM_VULKAN 3
 #define VIRTIO_GPU_CAPSET_VENUS 4
 #define VIRTIO_GPU_CAPSET_CROSS_DOMAIN 5
 struct virtio_gpu_resp_capset_info {
-- 
2.45.2

[PATCH v3 2/3] virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM

[Dmitry Osipenko]

Document VIRTIO_GPU_CAPSET_DRM that is capset for the DRM native context
protocols which implement Linux DRM UAPIs over VirtIO-GPU, effectively
exposing host GPU to a Linux guest like it's a native/baremetal GPU.

Acked-by: Huang Rui <ray.huang@amd.com>
Link: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14900
Link: https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/693
Link: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21658
Link: https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1274
Link: https://gitlab.freedesktop.org/digetx/mesa/-/commits/native-context-iris
Link: https://chromium.googlesource.com/chromiumos/platform/crosvm/+/69ecfb0e3913a4cd9048056f9a37cc496c7b9235
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 device-types/gpu/description.tex | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/device-types/gpu/description.tex b/device-types/gpu/description.tex
index 4b8dd7733c31..29c8a97c3a3f 100644
--- a/device-types/gpu/description.tex
+++ b/device-types/gpu/description.tex
@@ -536,6 +536,8 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 	Mesa's (mostly) autogenerated Vulkan protocol.
   \item \href{https://chromium.googlesource.com/chromiumos/platform/crosvm/+/refs/heads/main/rutabaga_gfx/src/cross_domain/cross_domain_protocol.rs}{VIRTIO_GPU_CAPSET_CROSS_DOMAIN} --
 	protocol for display virtualization via Wayland proxying.
+  \item \href{https://gitlab.freedesktop.org/virgl/virglrenderer/-/tree/master/src/drm}{VIRTIO_GPU_CAPSET_DRM} --
+	DRM native context protocols.
   \end{itemize*}
 
 \begin{lstlisting}
@@ -550,6 +552,7 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 #define VIRTIO_GPU_CAPSET_GFXSTREAM_VULKAN 3
 #define VIRTIO_GPU_CAPSET_VENUS 4
 #define VIRTIO_GPU_CAPSET_CROSS_DOMAIN 5
+#define VIRTIO_GPU_CAPSET_DRM 6
 struct virtio_gpu_resp_capset_info {
         struct virtio_gpu_ctrl_hdr hdr;
         le32 capset_id;
-- 
2.45.2

[PATCH v3 3/3] virtio-gpu: Update venus-protocol URL

[Dmitry Osipenko]

The venus-protocol was moved to the main virgl gitlab group a year ago.
Update the link in the GPU documentation.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 device-types/gpu/description.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/device-types/gpu/description.tex b/device-types/gpu/description.tex
index 29c8a97c3a3f..e633787aacad 100644
--- a/device-types/gpu/description.tex
+++ b/device-types/gpu/description.tex
@@ -532,7 +532,7 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
 	the second edition of Virgl (Gallium OpenGL) protocol after the capset fix.
   \item \href{https://android.googlesource.com/device/generic/vulkan-cereal/+/refs/heads/android13-release/protocols/vulkan/}{VIRTIO_GPU_CAPSET_GFXSTREAM_VULKAN} --
 	gfxtream's (mostly) autogenerated Vulkan streaming protocol.
-  \item \href{https://gitlab.freedesktop.org/olv/venus-protocol}{VIRTIO_GPU_CAPSET_VENUS} --
+  \item \href{https://gitlab.freedesktop.org/virgl/venus-protocol}{VIRTIO_GPU_CAPSET_VENUS} --
 	Mesa's (mostly) autogenerated Vulkan protocol.
   \item \href{https://chromium.googlesource.com/chromiumos/platform/crosvm/+/refs/heads/main/rutabaga_gfx/src/cross_domain/cross_domain_protocol.rs}{VIRTIO_GPU_CAPSET_CROSS_DOMAIN} --
 	protocol for display virtualization via Wayland proxying.
-- 
2.45.2

Re: [PATCH v3 0/3] VirtIO-GPU spec improvements

[Gerd Hoffmann]

On Fri, Jul 19, 2024 at 03:06:34PM GMT, Dmitry Osipenko wrote:
> Hi,
> 
> This is a repost of v2 to the new virtio-comment mailing list.
> Michael Tsirkin suggested to repost the patches, here they are.

Series:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

Re: [PATCH v3 0/3] VirtIO-GPU spec improvements

[Dmitry Osipenko]

On 7/19/24 15:06, Dmitry Osipenko wrote:
> Hi,
> 
> This is a repost of v2 to the new virtio-comment mailing list.
> Michael Tsirkin suggested to repost the patches, here they are.
> 
> Dmitry Osipenko (3):
>   virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN
>   virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM
>   virtio-gpu: Update venus-protocol URL
> 
>  device-types/gpu/description.tex | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/182

-- 
Best regards,
Dmitry

Re: [PATCH v3 0/3] VirtIO-GPU spec improvements

[Matias Ezequiel Vara Larsen]

On Wed, Feb 26, 2025 at 01:59:06PM +0300, Dmitry Osipenko wrote:
> On 7/19/24 15:06, Dmitry Osipenko wrote:
> > Hi,
> > 
> > This is a repost of v2 to the new virtio-comment mailing list.
> > Michael Tsirkin suggested to repost the patches, here they are.
> > 
> > Dmitry Osipenko (3):
> >   virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN
> >   virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM
> >   virtio-gpu: Update venus-protocol URL
> > 
> >  device-types/gpu/description.tex | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> > 
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/182
> 
I think what is missing is to explicitly request a vote as is explained
in 2) at
https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues.

Thanks, Matias

Re: [PATCH v3 0/3] VirtIO-GPU spec improvements

[Michael S. Tsirkin]

On Wed, Feb 26, 2025 at 05:08:02PM +0100, Matias Ezequiel Vara Larsen wrote:
> On Wed, Feb 26, 2025 at 01:59:06PM +0300, Dmitry Osipenko wrote:
> > On 7/19/24 15:06, Dmitry Osipenko wrote:
> > > Hi,
> > > 
> > > This is a repost of v2 to the new virtio-comment mailing list.
> > > Michael Tsirkin suggested to repost the patches, here they are.
> > > 
> > > Dmitry Osipenko (3):
> > >   virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN
> > >   virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM
> > >   virtio-gpu: Update venus-protocol URL
> > > 
> > >  device-types/gpu/description.tex | 11 +++++++----
> > >  1 file changed, 7 insertions(+), 4 deletions(-)
> > > 
> > 
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/182
> > 
> I think what is missing is to explicitly request a vote as is explained
> in 2) at
> https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues.
> 
> Thanks, Matias


if a vote is already desired, then yes.

Re: [PATCH v3 0/3] VirtIO-GPU spec improvements

[Dmitry Osipenko]

On 2/26/25 20:29, Michael S. Tsirkin wrote:
> On Wed, Feb 26, 2025 at 05:08:02PM +0100, Matias Ezequiel Vara Larsen wrote:
>> On Wed, Feb 26, 2025 at 01:59:06PM +0300, Dmitry Osipenko wrote:
>>> On 7/19/24 15:06, Dmitry Osipenko wrote:
>>>> Hi,
>>>>
>>>> This is a repost of v2 to the new virtio-comment mailing list.
>>>> Michael Tsirkin suggested to repost the patches, here they are.
>>>>
>>>> Dmitry Osipenko (3):
>>>>   virtio-gpu: Rename GFXSTREAM context capset to GFXSTREAM_VULKAN
>>>>   virtio-gpu: Document VIRTIO_GPU_CAPSET_DRM
>>>>   virtio-gpu: Update venus-protocol URL
>>>>
>>>>  device-types/gpu/description.tex | 11 +++++++----
>>>>  1 file changed, 7 insertions(+), 4 deletions(-)
>>>>
>>>
>>> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/182
>>>
>> I think what is missing is to explicitly request a vote as is explained
>> in 2) at
>> https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues.
>>
>> Thanks, Matias
> 
> 
> if a vote is already desired, then yes.

Please open the vote.


-- 
Best regards,
Dmitry