* Re: [PATCH v3] git-publish: add profile
2025-03-05 16:45 [PATCH v3] git-publish: add profile Matias Ezequiel Vara Larsen
@ 2025-03-06 5:22 ` Stefan Hajnoczi
2025-03-06 9:40 ` Matias Ezequiel Vara Larsen
2025-03-06 9:58 ` Stefano Garzarella
2025-03-06 10:04 ` Stefano Garzarella
` (3 subsequent siblings)
4 siblings, 2 replies; 13+ messages in thread
From: Stefan Hajnoczi @ 2025-03-06 5:22 UTC (permalink / raw)
To: Matias Ezequiel Vara Larsen; +Cc: virtio-comment, aesteve, sgarzare
[-- Attachment #1: Type: text/plain, Size: 2223 bytes --]
On Wed, Mar 05, 2025 at 05:45:46PM +0100, Matias Ezequiel Vara Larsen wrote:
> Add git-publish profile and document how to use it.
>
> Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> ---
> v2 -> v3:
> * remove uppercase and the line split and use italic
> v1 -> v2:
> * add link to git-publish
> * document that the project contains a profile already
> ---
> .gitpublish | 3 +++
> README.md | 15 +++++++++++++++
> 2 files changed, 18 insertions(+)
> create mode 100644 .gitpublish
>
> diff --git a/.gitpublish b/.gitpublish
> new file mode 100644
> index 0000000..d412896
> --- /dev/null
> +++ b/.gitpublish
> @@ -0,0 +1,3 @@
> +[gitpublishprofile "default"]
Great, this will make it easier to send spec changes!
> +base = master
> +to = virtio-comment@lists.linux.dev
From https://github.com/oasis-tcs/virtio-spec?tab=readme-ov-file:
When not to use the virtio-comment mailing list:
questions and change proposals for Virtio drivers and devices
implementing the specification. (please use the virtio-dev mailing
list for this).
This also matches what I found in my .git/config where gitpublishto was
set to virtio-dev rather than virtio-comment.
> diff --git a/README.md b/README.md
> index c06caf6..b521978 100644
> --- a/README.md
> +++ b/README.md
> @@ -110,6 +110,21 @@ git format-patch -o proposal1/ HEAD~1..<br>
> git send-email --to=virtio-comment@lists.linux.dev proposal1/0001-*
> </code>
>
> +<dl>Optionally, you can use <a
> +href="https://github.com/stefanha/git-publish">git-publish</a> to submit a
> +patch. This project already contains a <em>git-publish</em> profile that will
> +configure some fields, e.g., <em>To</em> field with the right address. After you have
> +installed <em>git-publish</em>, the procedure is the following:
> +
> +<code>
> +<p>
> +git checkout master -b my-feature<br>
> +# work on new commits, add your 'Signed-off-by' lines to each<br>
> +git publish<br>
> +# more work, rebase on master, ...<br>
> +git publish # will send a v2<br>
> +</code>
> +</dl>
> <dl>
> <dt>When to use the virtio-comment mailing list:</dt>
> <dd>
> --
> 2.42.0
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v3] git-publish: add profile
2025-03-06 5:22 ` Stefan Hajnoczi
@ 2025-03-06 9:40 ` Matias Ezequiel Vara Larsen
2025-03-06 9:58 ` Stefano Garzarella
1 sibling, 0 replies; 13+ messages in thread
From: Matias Ezequiel Vara Larsen @ 2025-03-06 9:40 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: virtio-comment, aesteve, sgarzare
On Thu, Mar 06, 2025 at 01:22:31PM +0800, Stefan Hajnoczi wrote:
> On Wed, Mar 05, 2025 at 05:45:46PM +0100, Matias Ezequiel Vara Larsen wrote:
> > Add git-publish profile and document how to use it.
> >
> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > ---
> > v2 -> v3:
> > * remove uppercase and the line split and use italic
> > v1 -> v2:
> > * add link to git-publish
> > * document that the project contains a profile already
> > ---
> > .gitpublish | 3 +++
> > README.md | 15 +++++++++++++++
> > 2 files changed, 18 insertions(+)
> > create mode 100644 .gitpublish
> >
> > diff --git a/.gitpublish b/.gitpublish
> > new file mode 100644
> > index 0000000..d412896
> > --- /dev/null
> > +++ b/.gitpublish
> > @@ -0,0 +1,3 @@
> > +[gitpublishprofile "default"]
>
> Great, this will make it easier to send spec changes!
>
> > +base = master
> > +to = virtio-comment@lists.linux.dev
>
> From https://github.com/oasis-tcs/virtio-spec?tab=readme-ov-file:
>
> When not to use the virtio-comment mailing list:
> questions and change proposals for Virtio drivers and devices
> implementing the specification. (please use the virtio-dev mailing
> list for this).
Are you proposing to add a comment in the .gitpublish to warn when the
virtio-comment list must not be used?
Thanks.
>
> This also matches what I found in my .git/config where gitpublishto was
> set to virtio-dev rather than virtio-comment.
>
> > diff --git a/README.md b/README.md
> > index c06caf6..b521978 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -110,6 +110,21 @@ git format-patch -o proposal1/ HEAD~1..<br>
> > git send-email --to=virtio-comment@lists.linux.dev proposal1/0001-*
> > </code>
> >
> > +<dl>Optionally, you can use <a
> > +href="https://github.com/stefanha/git-publish">git-publish</a> to submit a
> > +patch. This project already contains a <em>git-publish</em> profile that will
> > +configure some fields, e.g., <em>To</em> field with the right address. After you have
> > +installed <em>git-publish</em>, the procedure is the following:
> > +
> > +<code>
> > +<p>
> > +git checkout master -b my-feature<br>
> > +# work on new commits, add your 'Signed-off-by' lines to each<br>
> > +git publish<br>
> > +# more work, rebase on master, ...<br>
> > +git publish # will send a v2<br>
> > +</code>
> > +</dl>
> > <dl>
> > <dt>When to use the virtio-comment mailing list:</dt>
> > <dd>
> > --
> > 2.42.0
> >
> >
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3] git-publish: add profile
2025-03-06 5:22 ` Stefan Hajnoczi
2025-03-06 9:40 ` Matias Ezequiel Vara Larsen
@ 2025-03-06 9:58 ` Stefano Garzarella
2025-03-06 10:43 ` Albert Esteve
1 sibling, 1 reply; 13+ messages in thread
From: Stefano Garzarella @ 2025-03-06 9:58 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Matias Ezequiel Vara Larsen, virtio-comment, aesteve
On Thu, 6 Mar 2025 at 06:24, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> On Wed, Mar 05, 2025 at 05:45:46PM +0100, Matias Ezequiel Vara Larsen wrote:
> > Add git-publish profile and document how to use it.
> >
> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > ---
> > v2 -> v3:
> > * remove uppercase and the line split and use italic
> > v1 -> v2:
> > * add link to git-publish
> > * document that the project contains a profile already
> > ---
> > .gitpublish | 3 +++
> > README.md | 15 +++++++++++++++
> > 2 files changed, 18 insertions(+)
> > create mode 100644 .gitpublish
> >
> > diff --git a/.gitpublish b/.gitpublish
> > new file mode 100644
> > index 0000000..d412896
> > --- /dev/null
> > +++ b/.gitpublish
> > @@ -0,0 +1,3 @@
> > +[gitpublishprofile "default"]
>
> Great, this will make it easier to send spec changes!
>
> > +base = master
> > +to = virtio-comment@lists.linux.dev
>
> From https://github.com/oasis-tcs/virtio-spec?tab=readme-ov-file:
>
> When not to use the virtio-comment mailing list:
> questions and change proposals for Virtio drivers and devices
> implementing the specification. (please use the virtio-dev mailing
> list for this).
That statement talks about the driver and device "implementing" the
spec, not the spec itself, indeed there is another statement:
When to use the virtio-comment mailing list:
questions and change proposals for the Virtio specification,
including the specification of basic functionality, transports and
devices.
So I guess this patch is right, since here we are talking about spec
changes.
BTW I'm honest, I'm always confused about virtio-comment and virtio-dev
xD, so another "Thank you" to Matias for this patch!
>
> This also matches what I found in my .git/config where gitpublishto was
> set to virtio-dev rather than virtio-comment.
IIUC this is wrong, you should use virtio-comment for spec changes.
Thanks,
Stefano
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v3] git-publish: add profile
2025-03-06 9:58 ` Stefano Garzarella
@ 2025-03-06 10:43 ` Albert Esteve
2025-03-06 10:51 ` Stefano Garzarella
0 siblings, 1 reply; 13+ messages in thread
From: Albert Esteve @ 2025-03-06 10:43 UTC (permalink / raw)
To: Stefano Garzarella
Cc: Stefan Hajnoczi, Matias Ezequiel Vara Larsen, virtio-comment
On Thu, Mar 6, 2025 at 10:58 AM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> On Thu, 6 Mar 2025 at 06:24, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > On Wed, Mar 05, 2025 at 05:45:46PM +0100, Matias Ezequiel Vara Larsen wrote:
> > > Add git-publish profile and document how to use it.
> > >
> > > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > ---
> > > v2 -> v3:
> > > * remove uppercase and the line split and use italic
> > > v1 -> v2:
> > > * add link to git-publish
> > > * document that the project contains a profile already
> > > ---
> > > .gitpublish | 3 +++
> > > README.md | 15 +++++++++++++++
> > > 2 files changed, 18 insertions(+)
> > > create mode 100644 .gitpublish
> > >
> > > diff --git a/.gitpublish b/.gitpublish
> > > new file mode 100644
> > > index 0000000..d412896
> > > --- /dev/null
> > > +++ b/.gitpublish
> > > @@ -0,0 +1,3 @@
> > > +[gitpublishprofile "default"]
> >
> > Great, this will make it easier to send spec changes!
> >
> > > +base = master
> > > +to = virtio-comment@lists.linux.dev
> >
> > From https://github.com/oasis-tcs/virtio-spec?tab=readme-ov-file:
> >
> > When not to use the virtio-comment mailing list:
> > questions and change proposals for Virtio drivers and devices
> > implementing the specification. (please use the virtio-dev mailing
> > list for this).
>
> That statement talks about the driver and device "implementing" the
> spec, not the spec itself, indeed there is another statement:
>
> When to use the virtio-comment mailing list:
> questions and change proposals for the Virtio specification,
> including the specification of basic functionality, transports and
> devices.
>
> So I guess this patch is right, since here we are talking about spec
> changes.
>
> BTW I'm honest, I'm always confused about virtio-comment and virtio-dev
> xD, so another "Thank you" to Matias for this patch!
I'm in that club too :D I had to fail once to get it right.
The problem with hardcoding the gitpublishto setting to the default
profile is that users need to be aware that if they need to send it to
virtio-dev, they need to manually remove virtio-comment and add
virtio-dev to the command line. I mean, the patch is good because in
most cases it will be the right mailing list to use. But perhaps it
would be nice to mention it in the README (at least, mention what is
the default), instead of relying on them going to .gitpublish file and
check?
>
> >
> > This also matches what I found in my .git/config where gitpublishto was
> > set to virtio-dev rather than virtio-comment.
>
> IIUC this is wrong, you should use virtio-comment for spec changes.
>
> Thanks,
> Stefano
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3] git-publish: add profile
2025-03-06 10:43 ` Albert Esteve
@ 2025-03-06 10:51 ` Stefano Garzarella
2025-03-06 16:13 ` Albert Esteve
0 siblings, 1 reply; 13+ messages in thread
From: Stefano Garzarella @ 2025-03-06 10:51 UTC (permalink / raw)
To: Albert Esteve
Cc: Stefan Hajnoczi, Matias Ezequiel Vara Larsen, virtio-comment
On Thu, 6 Mar 2025 at 11:44, Albert Esteve <aesteve@redhat.com> wrote:
>
> On Thu, Mar 6, 2025 at 10:58 AM Stefano Garzarella <sgarzare@redhat.com> wrote:
> >
> > On Thu, 6 Mar 2025 at 06:24, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > >
> > > On Wed, Mar 05, 2025 at 05:45:46PM +0100, Matias Ezequiel Vara Larsen wrote:
> > > > Add git-publish profile and document how to use it.
> > > >
> > > > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > > ---
> > > > v2 -> v3:
> > > > * remove uppercase and the line split and use italic
> > > > v1 -> v2:
> > > > * add link to git-publish
> > > > * document that the project contains a profile already
> > > > ---
> > > > .gitpublish | 3 +++
> > > > README.md | 15 +++++++++++++++
> > > > 2 files changed, 18 insertions(+)
> > > > create mode 100644 .gitpublish
> > > >
> > > > diff --git a/.gitpublish b/.gitpublish
> > > > new file mode 100644
> > > > index 0000000..d412896
> > > > --- /dev/null
> > > > +++ b/.gitpublish
> > > > @@ -0,0 +1,3 @@
> > > > +[gitpublishprofile "default"]
> > >
> > > Great, this will make it easier to send spec changes!
> > >
> > > > +base = master
> > > > +to = virtio-comment@lists.linux.dev
> > >
> > > From https://github.com/oasis-tcs/virtio-spec?tab=readme-ov-file:
> > >
> > > When not to use the virtio-comment mailing list:
> > > questions and change proposals for Virtio drivers and devices
> > > implementing the specification. (please use the virtio-dev mailing
> > > list for this).
> >
> > That statement talks about the driver and device "implementing" the
> > spec, not the spec itself, indeed there is another statement:
> >
> > When to use the virtio-comment mailing list:
> > questions and change proposals for the Virtio specification,
> > including the specification of basic functionality, transports and
> > devices.
> >
> > So I guess this patch is right, since here we are talking about spec
> > changes.
> >
> > BTW I'm honest, I'm always confused about virtio-comment and virtio-dev
> > xD, so another "Thank you" to Matias for this patch!
>
> I'm in that club too :D I had to fail once to get it right.
:D
>
> The problem with hardcoding the gitpublishto setting to the default
> profile is that users need to be aware that if they need to send it to
> virtio-dev, they need to manually remove virtio-comment and add
> virtio-dev to the command line. I mean, the patch is good because in
> most cases it will be the right mailing list to use. But perhaps it
> would be nice to mention it in the README (at least, mention what is
> the default), instead of relying on them going to .gitpublish file and
> check?
I see, but do we really have a case where changes to the spec need to
be sent to virtio-dev?
If not, I'd avoid to mention to increase confusion.
If yes, maybe we can add another profile section in the .gitpublish
file, with a different "To:", and mention in the readme, but I'm not
sure if we want people sending changes of this repo to virtio-dev.
Thanks,
Stefano
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3] git-publish: add profile
2025-03-06 10:51 ` Stefano Garzarella
@ 2025-03-06 16:13 ` Albert Esteve
2025-03-11 2:17 ` Stefan Hajnoczi
0 siblings, 1 reply; 13+ messages in thread
From: Albert Esteve @ 2025-03-06 16:13 UTC (permalink / raw)
To: Stefano Garzarella
Cc: Stefan Hajnoczi, Matias Ezequiel Vara Larsen, virtio-comment
On Thu, Mar 6, 2025 at 11:51 AM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> On Thu, 6 Mar 2025 at 11:44, Albert Esteve <aesteve@redhat.com> wrote:
> >
> > On Thu, Mar 6, 2025 at 10:58 AM Stefano Garzarella <sgarzare@redhat.com> wrote:
> > >
> > > On Thu, 6 Mar 2025 at 06:24, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > > >
> > > > On Wed, Mar 05, 2025 at 05:45:46PM +0100, Matias Ezequiel Vara Larsen wrote:
> > > > > Add git-publish profile and document how to use it.
> > > > >
> > > > > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > > > ---
> > > > > v2 -> v3:
> > > > > * remove uppercase and the line split and use italic
> > > > > v1 -> v2:
> > > > > * add link to git-publish
> > > > > * document that the project contains a profile already
> > > > > ---
> > > > > .gitpublish | 3 +++
> > > > > README.md | 15 +++++++++++++++
> > > > > 2 files changed, 18 insertions(+)
> > > > > create mode 100644 .gitpublish
> > > > >
> > > > > diff --git a/.gitpublish b/.gitpublish
> > > > > new file mode 100644
> > > > > index 0000000..d412896
> > > > > --- /dev/null
> > > > > +++ b/.gitpublish
> > > > > @@ -0,0 +1,3 @@
> > > > > +[gitpublishprofile "default"]
> > > >
> > > > Great, this will make it easier to send spec changes!
> > > >
> > > > > +base = master
> > > > > +to = virtio-comment@lists.linux.dev
> > > >
> > > > From https://github.com/oasis-tcs/virtio-spec?tab=readme-ov-file:
> > > >
> > > > When not to use the virtio-comment mailing list:
> > > > questions and change proposals for Virtio drivers and devices
> > > > implementing the specification. (please use the virtio-dev mailing
> > > > list for this).
> > >
> > > That statement talks about the driver and device "implementing" the
> > > spec, not the spec itself, indeed there is another statement:
> > >
> > > When to use the virtio-comment mailing list:
> > > questions and change proposals for the Virtio specification,
> > > including the specification of basic functionality, transports and
> > > devices.
> > >
> > > So I guess this patch is right, since here we are talking about spec
> > > changes.
> > >
> > > BTW I'm honest, I'm always confused about virtio-comment and virtio-dev
> > > xD, so another "Thank you" to Matias for this patch!
> >
> > I'm in that club too :D I had to fail once to get it right.
>
> :D
>
> >
> > The problem with hardcoding the gitpublishto setting to the default
> > profile is that users need to be aware that if they need to send it to
> > virtio-dev, they need to manually remove virtio-comment and add
> > virtio-dev to the command line. I mean, the patch is good because in
> > most cases it will be the right mailing list to use. But perhaps it
> > would be nice to mention it in the README (at least, mention what is
> > the default), instead of relying on them going to .gitpublish file and
> > check?
>
> I see, but do we really have a case where changes to the spec need to
> be sent to virtio-dev?
Judging by the README I'd say probably not? But looking at the
messages in the list, I found one example of a spec change in
virtio-dev [1]. Although that is not a good reason per se, as it may
just be using the wrong list.
[1] https://lore.kernel.org/virtio-dev/20241107105103.19152-1-mgurtovoy@nvidia.com/T/#u
>
> If not, I'd avoid to mention to increase confusion.
Yeah, let's do that then.
> If yes, maybe we can add another profile section in the .gitpublish
> file, with a different "To:", and mention in the readme, but I'm not
> sure if we want people sending changes of this repo to virtio-dev.
>
> Thanks,
> Stefano
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3] git-publish: add profile
2025-03-06 16:13 ` Albert Esteve
@ 2025-03-11 2:17 ` Stefan Hajnoczi
0 siblings, 0 replies; 13+ messages in thread
From: Stefan Hajnoczi @ 2025-03-11 2:17 UTC (permalink / raw)
To: Albert Esteve
Cc: Stefano Garzarella, Matias Ezequiel Vara Larsen, virtio-comment
[-- Attachment #1: Type: text/plain, Size: 3941 bytes --]
On Thu, Mar 06, 2025 at 05:13:20PM +0100, Albert Esteve wrote:
> On Thu, Mar 6, 2025 at 11:51 AM Stefano Garzarella <sgarzare@redhat.com> wrote:
> >
> > On Thu, 6 Mar 2025 at 11:44, Albert Esteve <aesteve@redhat.com> wrote:
> > >
> > > On Thu, Mar 6, 2025 at 10:58 AM Stefano Garzarella <sgarzare@redhat.com> wrote:
> > > >
> > > > On Thu, 6 Mar 2025 at 06:24, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > > > >
> > > > > On Wed, Mar 05, 2025 at 05:45:46PM +0100, Matias Ezequiel Vara Larsen wrote:
> > > > > > Add git-publish profile and document how to use it.
> > > > > >
> > > > > > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > > > > ---
> > > > > > v2 -> v3:
> > > > > > * remove uppercase and the line split and use italic
> > > > > > v1 -> v2:
> > > > > > * add link to git-publish
> > > > > > * document that the project contains a profile already
> > > > > > ---
> > > > > > .gitpublish | 3 +++
> > > > > > README.md | 15 +++++++++++++++
> > > > > > 2 files changed, 18 insertions(+)
> > > > > > create mode 100644 .gitpublish
> > > > > >
> > > > > > diff --git a/.gitpublish b/.gitpublish
> > > > > > new file mode 100644
> > > > > > index 0000000..d412896
> > > > > > --- /dev/null
> > > > > > +++ b/.gitpublish
> > > > > > @@ -0,0 +1,3 @@
> > > > > > +[gitpublishprofile "default"]
> > > > >
> > > > > Great, this will make it easier to send spec changes!
> > > > >
> > > > > > +base = master
> > > > > > +to = virtio-comment@lists.linux.dev
> > > > >
> > > > > From https://github.com/oasis-tcs/virtio-spec?tab=readme-ov-file:
> > > > >
> > > > > When not to use the virtio-comment mailing list:
> > > > > questions and change proposals for Virtio drivers and devices
> > > > > implementing the specification. (please use the virtio-dev mailing
> > > > > list for this).
> > > >
> > > > That statement talks about the driver and device "implementing" the
> > > > spec, not the spec itself, indeed there is another statement:
> > > >
> > > > When to use the virtio-comment mailing list:
> > > > questions and change proposals for the Virtio specification,
> > > > including the specification of basic functionality, transports and
> > > > devices.
> > > >
> > > > So I guess this patch is right, since here we are talking about spec
> > > > changes.
> > > >
> > > > BTW I'm honest, I'm always confused about virtio-comment and virtio-dev
> > > > xD, so another "Thank you" to Matias for this patch!
> > >
> > > I'm in that club too :D I had to fail once to get it right.
> >
> > :D
> >
> > >
> > > The problem with hardcoding the gitpublishto setting to the default
> > > profile is that users need to be aware that if they need to send it to
> > > virtio-dev, they need to manually remove virtio-comment and add
> > > virtio-dev to the command line. I mean, the patch is good because in
> > > most cases it will be the right mailing list to use. But perhaps it
> > > would be nice to mention it in the README (at least, mention what is
> > > the default), instead of relying on them going to .gitpublish file and
> > > check?
> >
> > I see, but do we really have a case where changes to the spec need to
> > be sent to virtio-dev?
>
> Judging by the README I'd say probably not? But looking at the
> messages in the list, I found one example of a spec change in
> virtio-dev [1]. Although that is not a good reason per se, as it may
> just be using the wrong list.
>
> [1] https://lore.kernel.org/virtio-dev/20241107105103.19152-1-mgurtovoy@nvidia.com/T/#u
>
> >
> > If not, I'd avoid to mention to increase confusion.
>
> Yeah, let's do that then.
I read the README.md more carefully and I think Stefano is right:
patches should be sent to virtio-comment.
There's no need to mention virtio-dev.
I was just doing it wrong all along :D.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3] git-publish: add profile
2025-03-05 16:45 [PATCH v3] git-publish: add profile Matias Ezequiel Vara Larsen
2025-03-06 5:22 ` Stefan Hajnoczi
@ 2025-03-06 10:04 ` Stefano Garzarella
2025-03-06 16:15 ` Albert Esteve
` (2 subsequent siblings)
4 siblings, 0 replies; 13+ messages in thread
From: Stefano Garzarella @ 2025-03-06 10:04 UTC (permalink / raw)
To: Matias Ezequiel Vara Larsen; +Cc: virtio-comment, aesteve
On Wed, Mar 05, 2025 at 05:45:46PM +0100, Matias Ezequiel Vara Larsen wrote:
>Add git-publish profile and document how to use it.
>
>Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
>---
>v2 -> v3:
> * remove uppercase and the line split and use italic
>v1 -> v2:
> * add link to git-publish
> * document that the project contains a profile already
>---
> .gitpublish | 3 +++
> README.md | 15 +++++++++++++++
> 2 files changed, 18 insertions(+)
> create mode 100644 .gitpublish
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/.gitpublish b/.gitpublish
>new file mode 100644
>index 0000000..d412896
>--- /dev/null
>+++ b/.gitpublish
>@@ -0,0 +1,3 @@
>+[gitpublishprofile "default"]
>+base = master
>+to = virtio-comment@lists.linux.dev
>diff --git a/README.md b/README.md
>index c06caf6..b521978 100644
>--- a/README.md
>+++ b/README.md
>@@ -110,6 +110,21 @@ git format-patch -o proposal1/ HEAD~1..<br>
> git send-email --to=virtio-comment@lists.linux.dev proposal1/0001-*
> </code>
>
>+<dl>Optionally, you can use <a
>+href="https://github.com/stefanha/git-publish">git-publish</a> to submit a
>+patch. This project already contains a <em>git-publish</em> profile that will
>+configure some fields, e.g., <em>To</em> field with the right address. After you have
>+installed <em>git-publish</em>, the procedure is the following:
>+
>+<code>
>+<p>
>+git checkout master -b my-feature<br>
>+# work on new commits, add your 'Signed-off-by' lines to each<br>
>+git publish<br>
>+# more work, rebase on master, ...<br>
>+git publish # will send a v2<br>
>+</code>
>+</dl>
> <dl>
> <dt>When to use the virtio-comment mailing list:</dt>
> <dd>
>--
>2.42.0
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v3] git-publish: add profile
2025-03-05 16:45 [PATCH v3] git-publish: add profile Matias Ezequiel Vara Larsen
2025-03-06 5:22 ` Stefan Hajnoczi
2025-03-06 10:04 ` Stefano Garzarella
@ 2025-03-06 16:15 ` Albert Esteve
2025-03-10 13:21 ` Cornelia Huck
2025-09-23 8:09 ` Matias Ezequiel Vara Larsen
4 siblings, 0 replies; 13+ messages in thread
From: Albert Esteve @ 2025-03-06 16:15 UTC (permalink / raw)
To: Matias Ezequiel Vara Larsen; +Cc: virtio-comment, sgarzare
On Wed, Mar 5, 2025 at 5:45 PM Matias Ezequiel Vara Larsen
<mvaralar@redhat.com> wrote:
>
> Add git-publish profile and document how to use it.
>
> Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> ---
> v2 -> v3:
> * remove uppercase and the line split and use italic
> v1 -> v2:
> * add link to git-publish
> * document that the project contains a profile already
> ---
> .gitpublish | 3 +++
> README.md | 15 +++++++++++++++
> 2 files changed, 18 insertions(+)
> create mode 100644 .gitpublish
Reviewed-by: Albert Esteve <aesteve@redhat.com>
>
> diff --git a/.gitpublish b/.gitpublish
> new file mode 100644
> index 0000000..d412896
> --- /dev/null
> +++ b/.gitpublish
> @@ -0,0 +1,3 @@
> +[gitpublishprofile "default"]
> +base = master
> +to = virtio-comment@lists.linux.dev
> diff --git a/README.md b/README.md
> index c06caf6..b521978 100644
> --- a/README.md
> +++ b/README.md
> @@ -110,6 +110,21 @@ git format-patch -o proposal1/ HEAD~1..<br>
> git send-email --to=virtio-comment@lists.linux.dev proposal1/0001-*
> </code>
>
> +<dl>Optionally, you can use <a
> +href="https://github.com/stefanha/git-publish">git-publish</a> to submit a
> +patch. This project already contains a <em>git-publish</em> profile that will
> +configure some fields, e.g., <em>To</em> field with the right address. After you have
> +installed <em>git-publish</em>, the procedure is the following:
> +
> +<code>
> +<p>
> +git checkout master -b my-feature<br>
> +# work on new commits, add your 'Signed-off-by' lines to each<br>
> +git publish<br>
> +# more work, rebase on master, ...<br>
> +git publish # will send a v2<br>
> +</code>
> +</dl>
> <dl>
> <dt>When to use the virtio-comment mailing list:</dt>
> <dd>
> --
> 2.42.0
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3] git-publish: add profile
2025-03-05 16:45 [PATCH v3] git-publish: add profile Matias Ezequiel Vara Larsen
` (2 preceding siblings ...)
2025-03-06 16:15 ` Albert Esteve
@ 2025-03-10 13:21 ` Cornelia Huck
2025-09-23 8:09 ` Matias Ezequiel Vara Larsen
4 siblings, 0 replies; 13+ messages in thread
From: Cornelia Huck @ 2025-03-10 13:21 UTC (permalink / raw)
To: Matias Ezequiel Vara Larsen, virtio-comment
Cc: aesteve, sgarzare, Matias Ezequiel Vara Larsen
On Wed, Mar 05 2025, Matias Ezequiel Vara Larsen <mvaralar@redhat.com> wrote:
> Add git-publish profile and document how to use it.
>
> Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> ---
> v2 -> v3:
> * remove uppercase and the line split and use italic
> v1 -> v2:
> * add link to git-publish
> * document that the project contains a profile already
> ---
> .gitpublish | 3 +++
> README.md | 15 +++++++++++++++
> 2 files changed, 18 insertions(+)
> create mode 100644 .gitpublish
>
> diff --git a/.gitpublish b/.gitpublish
> new file mode 100644
> index 0000000..d412896
> --- /dev/null
> +++ b/.gitpublish
> @@ -0,0 +1,3 @@
> +[gitpublishprofile "default"]
> +base = master
> +to = virtio-comment@lists.linux.dev
> diff --git a/README.md b/README.md
> index c06caf6..b521978 100644
> --- a/README.md
> +++ b/README.md
> @@ -110,6 +110,21 @@ git format-patch -o proposal1/ HEAD~1..<br>
> git send-email --to=virtio-comment@lists.linux.dev proposal1/0001-*
> </code>
>
> +<dl>Optionally, you can use <a
> +href="https://github.com/stefanha/git-publish">git-publish</a> to submit a
> +patch. This project already contains a <em>git-publish</em> profile that will
> +configure some fields, e.g., <em>To</em> field with the right address. After you have
> +installed <em>git-publish</em>, the procedure is the following:
> +
> +<code>
> +<p>
> +git checkout master -b my-feature<br>
> +# work on new commits, add your 'Signed-off-by' lines to each<br>
> +git publish<br>
> +# more work, rebase on master, ...<br>
> +git publish # will send a v2<br>
> +</code>
> +</dl>
> <dl>
> <dt>When to use the virtio-comment mailing list:</dt>
> <dd>
Acked-by: Cornelia Huck <cohuck@redhat.com>
I think this can be done as an editorial update.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v3] git-publish: add profile
2025-03-05 16:45 [PATCH v3] git-publish: add profile Matias Ezequiel Vara Larsen
` (3 preceding siblings ...)
2025-03-10 13:21 ` Cornelia Huck
@ 2025-09-23 8:09 ` Matias Ezequiel Vara Larsen
2025-09-23 12:14 ` Parav Pandit
4 siblings, 1 reply; 13+ messages in thread
From: Matias Ezequiel Vara Larsen @ 2025-09-23 8:09 UTC (permalink / raw)
To: virtio-comment; +Cc: aesteve, sgarzare, parav
On Wed, Mar 05, 2025 at 05:45:46PM +0100, Matias Ezequiel Vara Larsen wrote:
> Add git-publish profile and document how to use it.
>
> Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> ---
> v2 -> v3:
> * remove uppercase and the line split and use italic
> v1 -> v2:
> * add link to git-publish
> * document that the project contains a profile already
> ---
> .gitpublish | 3 +++
> README.md | 15 +++++++++++++++
> 2 files changed, 18 insertions(+)
> create mode 100644 .gitpublish
>
Hello @Parav, I can't remember if this have been merged already. Since
this is a non-editorial change, I do not think require opening a ballot.
Matias
> diff --git a/.gitpublish b/.gitpublish
> new file mode 100644
> index 0000000..d412896
> --- /dev/null
> +++ b/.gitpublish
> @@ -0,0 +1,3 @@
> +[gitpublishprofile "default"]
> +base = master
> +to = virtio-comment@lists.linux.dev
> diff --git a/README.md b/README.md
> index c06caf6..b521978 100644
> --- a/README.md
> +++ b/README.md
> @@ -110,6 +110,21 @@ git format-patch -o proposal1/ HEAD~1..<br>
> git send-email --to=virtio-comment@lists.linux.dev proposal1/0001-*
> </code>
>
> +<dl>Optionally, you can use <a
> +href="https://github.com/stefanha/git-publish">git-publish</a> to submit a
> +patch. This project already contains a <em>git-publish</em> profile that will
> +configure some fields, e.g., <em>To</em> field with the right address. After you have
> +installed <em>git-publish</em>, the procedure is the following:
> +
> +<code>
> +<p>
> +git checkout master -b my-feature<br>
> +# work on new commits, add your 'Signed-off-by' lines to each<br>
> +git publish<br>
> +# more work, rebase on master, ...<br>
> +git publish # will send a v2<br>
> +</code>
> +</dl>
> <dl>
> <dt>When to use the virtio-comment mailing list:</dt>
> <dd>
> --
> 2.42.0
>
^ permalink raw reply [flat|nested] 13+ messages in thread* RE: [PATCH v3] git-publish: add profile
2025-09-23 8:09 ` Matias Ezequiel Vara Larsen
@ 2025-09-23 12:14 ` Parav Pandit
0 siblings, 0 replies; 13+ messages in thread
From: Parav Pandit @ 2025-09-23 12:14 UTC (permalink / raw)
To: Matias Ezequiel Vara Larsen, virtio-comment@lists.linux.dev
Cc: aesteve@redhat.com, sgarzare@redhat.com
Hi Matias,
> From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> Sent: 23 September 2025 01:39 PM
>
> On Wed, Mar 05, 2025 at 05:45:46PM +0100, Matias Ezequiel Vara Larsen
> wrote:
> > Add git-publish profile and document how to use it.
> >
> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > ---
> > v2 -> v3:
> > * remove uppercase and the line split and use italic
> > v1 -> v2:
> > * add link to git-publish
> > * document that the project contains a profile already
> > ---
> > .gitpublish | 3 +++
> > README.md | 15 +++++++++++++++
> > 2 files changed, 18 insertions(+)
> > create mode 100644 .gitpublish
> >
>
> Hello @Parav, I can't remember if this have been merged already. Since
> this is a non-editorial change, I do not think require opening a ballot.
>
Right.
I merged now.
> Matias
>
> > diff --git a/.gitpublish b/.gitpublish
> > new file mode 100644
> > index 0000000..d412896
> > --- /dev/null
> > +++ b/.gitpublish
> > @@ -0,0 +1,3 @@
> > +[gitpublishprofile "default"]
> > +base = master
> > +to = virtio-comment@lists.linux.dev
> > diff --git a/README.md b/README.md
> > index c06caf6..b521978 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -110,6 +110,21 @@ git format-patch -o proposal1/ HEAD~1..<br>
> > git send-email --to=virtio-comment@lists.linux.dev proposal1/0001-*
> > </code>
> >
> > +<dl>Optionally, you can use <a
> > +href="https://github.com/stefanha/git-publish">git-publish</a> to submit
> a
> > +patch. This project already contains a <em>git-publish</em> profile that
> will
> > +configure some fields, e.g., <em>To</em> field with the right address.
> After you have
> > +installed <em>git-publish</em>, the procedure is the following:
> > +
> > +<code>
> > +<p>
> > +git checkout master -b my-feature<br>
> > +# work on new commits, add your 'Signed-off-by' lines to each<br>
> > +git publish<br>
> > +# more work, rebase on master, ...<br>
> > +git publish # will send a v2<br>
> > +</code>
> > +</dl>
> > <dl>
> > <dt>When to use the virtio-comment mailing list:</dt>
> > <dd>
> > --
> > 2.42.0
> >
^ permalink raw reply [flat|nested] 13+ messages in thread