* [PATCH v4] README.md: add example email for TC vote request
@ 2025-03-11 21:20 Matias Ezequiel Vara Larsen
2025-03-11 22:09 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Matias Ezequiel Vara Larsen @ 2025-03-11 21:20 UTC (permalink / raw)
To: virtio-comment; +Cc: cohuck, parav, mst, Matias Ezequiel Vara Larsen
Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
---
v3 -> v4: add "[]"
v2 -> v3: use "()"
v1 -> v2: add Subject and To
---
README.md | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/README.md b/README.md
index c06caf6..f4b32ab 100644
--- a/README.md
+++ b/README.md
@@ -206,7 +206,16 @@ The mail requesting the vote should include the following, on a line by itself:<
<code>
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
</code>
-(NNN is the issue number)</li>
+(NNN is the issue number)<br>
+For example, you can use the following template when requesting the TC vote:<br>
+<code>
+Subject: [PATCH] (description of changes)<br>
+To: virtio-comment@lists.linux.dev<br>
+
+Could please open a voting ballot for these changes?
+
+Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
+</code></li>
<li>Please make sure to allow time for review between posting a comment
and asking for a vote. </li>
</ol>
base-commit: 124fcd0e97f209aab19639e7369116d99ede22a2
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4] README.md: add example email for TC vote request
2025-03-11 21:20 [PATCH v4] README.md: add example email for TC vote request Matias Ezequiel Vara Larsen
@ 2025-03-11 22:09 ` Michael S. Tsirkin
2025-03-12 9:09 ` Matias Ezequiel Vara Larsen
0 siblings, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2025-03-11 22:09 UTC (permalink / raw)
To: Matias Ezequiel Vara Larsen; +Cc: virtio-comment, cohuck, parav
On Tue, Mar 11, 2025 at 10:20:30PM +0100, Matias Ezequiel Vara Larsen wrote:
> Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> ---
> v3 -> v4: add "[]"
> v2 -> v3: use "()"
> v1 -> v2: add Subject and To
> ---
> README.md | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/README.md b/README.md
> index c06caf6..f4b32ab 100644
> --- a/README.md
> +++ b/README.md
> @@ -206,7 +206,16 @@ The mail requesting the vote should include the following, on a line by itself:<
> <code>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> </code>
> -(NNN is the issue number)</li>
> +(NNN is the issue number)<br>
> +For example, you can use the following template when requesting the TC vote:<br>
> +<code>
> +Subject: [PATCH] (description of changes)<br>
Wait wait, this should be in response to the patch, no?
Subject: Re: [PATCH] (description of changes)<br>
In-Reply-To: (message id of the patch)
> +To: virtio-comment@lists.linux.dev<br>
> +
> +Could please open a voting ballot for these changes?
> +
> +Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> +</code></li>
> <li>Please make sure to allow time for review between posting a comment
> and asking for a vote. </li>
> </ol>
>
> base-commit: 124fcd0e97f209aab19639e7369116d99ede22a2
> --
> 2.42.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] README.md: add example email for TC vote request
2025-03-11 22:09 ` Michael S. Tsirkin
@ 2025-03-12 9:09 ` Matias Ezequiel Vara Larsen
2025-03-12 11:23 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Matias Ezequiel Vara Larsen @ 2025-03-12 9:09 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: virtio-comment, cohuck, parav
On Tue, Mar 11, 2025 at 06:09:36PM -0400, Michael S. Tsirkin wrote:
> On Tue, Mar 11, 2025 at 10:20:30PM +0100, Matias Ezequiel Vara Larsen wrote:
> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > ---
> > v3 -> v4: add "[]"
> > v2 -> v3: use "()"
> > v1 -> v2: add Subject and To
> > ---
> > README.md | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/README.md b/README.md
> > index c06caf6..f4b32ab 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -206,7 +206,16 @@ The mail requesting the vote should include the following, on a line by itself:<
> > <code>
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> > </code>
> > -(NNN is the issue number)</li>
> > +(NNN is the issue number)<br>
> > +For example, you can use the following template when requesting the TC vote:<br>
> > +<code>
> > +Subject: [PATCH] (description of changes)<br>
>
> Wait wait, this should be in response to the patch, no?
>
> Subject: Re: [PATCH] (description of changes)<br>
> In-Reply-To: (message id of the patch)
>
>
The patch introduces a template to ensure that when requesting to open a
ballot, people include in the message both the GitHub issue link and the
request itself. Do you think Subject and In-Reply-To are important in
this context?
Matias
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] README.md: add example email for TC vote request
2025-03-12 9:09 ` Matias Ezequiel Vara Larsen
@ 2025-03-12 11:23 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2025-03-12 11:23 UTC (permalink / raw)
To: Matias Ezequiel Vara Larsen; +Cc: virtio-comment, cohuck, parav
On Wed, Mar 12, 2025 at 10:09:49AM +0100, Matias Ezequiel Vara Larsen wrote:
> On Tue, Mar 11, 2025 at 06:09:36PM -0400, Michael S. Tsirkin wrote:
> > On Tue, Mar 11, 2025 at 10:20:30PM +0100, Matias Ezequiel Vara Larsen wrote:
> > > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > ---
> > > v3 -> v4: add "[]"
> > > v2 -> v3: use "()"
> > > v1 -> v2: add Subject and To
> > > ---
> > > README.md | 11 ++++++++++-
> > > 1 file changed, 10 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/README.md b/README.md
> > > index c06caf6..f4b32ab 100644
> > > --- a/README.md
> > > +++ b/README.md
> > > @@ -206,7 +206,16 @@ The mail requesting the vote should include the following, on a line by itself:<
> > > <code>
> > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> > > </code>
> > > -(NNN is the issue number)</li>
> > > +(NNN is the issue number)<br>
> > > +For example, you can use the following template when requesting the TC vote:<br>
> > > +<code>
> > > +Subject: [PATCH] (description of changes)<br>
> >
> > Wait wait, this should be in response to the patch, no?
> >
> > Subject: Re: [PATCH] (description of changes)<br>
> > In-Reply-To: (message id of the patch)
> >
> >
>
> The patch introduces a template to ensure that when requesting to open a
> ballot, people include in the message both the GitHub issue link and the
> request itself. Do you think Subject and In-Reply-To are important in
> this context?
>
> Matias
If you like, just drop the subject completely.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-12 11:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-11 21:20 [PATCH v4] README.md: add example email for TC vote request Matias Ezequiel Vara Larsen
2025-03-11 22:09 ` Michael S. Tsirkin
2025-03-12 9:09 ` Matias Ezequiel Vara Larsen
2025-03-12 11:23 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox