From: Sergio Lopez <slp@redhat.com>
To: virtio-comment@lists.linux.dev
Cc: dmitry.osipenko@collabora.com, mst@redhat.com,
gurchetansingh@chromium.org, parav@nvidia.com,
Sergio Lopez <slp@redhat.com>
Subject: [PATCH] virtio-gpu: support blob alignment information
Date: Tue, 1 Apr 2025 13:42:03 -0400 [thread overview]
Message-ID: <20250401174203.161991-1-slp@redhat.com> (raw)
Allow the device to require certain alignment constrains for blob
resources by extending the device configuration with the field
"blob_alignment" and introducing the VIRTIO_GPU_F_BLOB_ALIGNMENT
feature.
Signed-off-by: Sergio Lopez <slp@redhat.com>
---
device-types/gpu/description.tex | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/device-types/gpu/description.tex b/device-types/gpu/description.tex
index 4435248..8e5258d 100644
--- a/device-types/gpu/description.tex
+++ b/device-types/gpu/description.tex
@@ -37,6 +37,8 @@ \subsection{Feature bits}\label{sec:Device Types / GPU Device / Feature bits}
resources is supported.
\item[VIRTIO_GPU_F_CONTEXT_INIT (4)] multiple context types and
synchronization timelines supported. Requires VIRTIO_GPU_F_VIRGL.
+\item[VIRTIO_GPU_F_BLOB_ALIGNMENT (5)] configuration field
+ \field{blob_alignment} is valid. Requires VIRTIO_GPU_F_RESOURCE_BLOB.
\end{description}
\subsection{Device configuration layout}\label{sec:Device Types / GPU Device / Device configuration layout}
@@ -52,6 +54,7 @@ \subsection{Device configuration layout}\label{sec:Device Types / GPU Device / D
le32 events_clear;
le32 num_scanouts;
le32 num_capsets;
+ le32 blob_alignment;
};
\end{lstlisting}
@@ -67,6 +70,8 @@ \subsubsection{Device configuration fields}
supported by the device. Minimum value is 1, maximum value is 16.
\item[\field{num_capsets}] specifies the maximum number of capability
sets supported by the device. The minimum value is zero.
+\item[\field{blob_alignment}] specifies the byte alignment required by
+ the device for resource blobs.
\end{description}
\subsubsection{Events}
@@ -672,6 +677,9 @@ \subsubsection{Device Operation: controlq}\label{sec:Device Types / GPU Device /
resource. There is no restriction on the image/buffer view the driver
has on the blob resource.
+If VIRTIO_GPU_F_BLOB_ALIGNMENT is set, \field{size} must be aligned to
+\field{blob_alignment} as defined in the device configuration.
+
\item[VIRTIO_GPU_CMD_SET_SCANOUT_BLOB] sets scanout parameters for a
blob resource. Request data is
\field{struct virtio_gpu_set_scanout_blob}. Response type is
@@ -776,6 +784,10 @@ \subsubsection{Device Operation: controlq (3d)}\label{sec:Device Types / GPU Dev
};
\end{lstlisting}
+If VIRTIO_GPU_F_BLOB_ALIGNMENT is set, \field{padding} and \field{offset}
+must be aligned to \field{blob_alignment} as defined in the device
+configuration.
+
\item[VIRTIO_GPU_CMD_RESOURCE_UNMAP_BLOB] unmaps a
host-only blob resource from the host visible memory region. Request data
is \field{struct virtio_gpu_resource_unmap_blob}. Response type is
--
2.49.0
next reply other threads:[~2025-04-03 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 17:42 Sergio Lopez [this message]
2025-04-03 16:27 ` [PATCH] virtio-gpu: support blob alignment information Michael S. Tsirkin
2025-04-03 16:55 ` Sergio Lopez Pascual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250401174203.161991-1-slp@redhat.com \
--to=slp@redhat.com \
--cc=dmitry.osipenko@collabora.com \
--cc=gurchetansingh@chromium.org \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox